[mathml] Ensure that <mtd> children are blockified.#59940
Draft
chromium-wpt-export-bot wants to merge 1 commit into
Draft
[mathml] Ensure that <mtd> children are blockified.#59940chromium-wpt-export-bot wants to merge 1 commit into
chromium-wpt-export-bot wants to merge 1 commit into
Conversation
We recently hardened the code within LayoutBlock::AddChild, see: https://chromium-review.googlesource.com/c/chromium/src/+/7836695 This revealed that an <mtd> isn't blockifiying its children when it should be. <mtd> elements create a special layout object which places all the children into an anonymous <mrow>. <mrow> children blockified under normal circumstances. This patch adds a monotonic_flag to the computed_style object which forces a style to blockify its children. This is needed (vs. just making ComputedStyle::BlockifiesChildren take an "const Element&" arg as we compare BlockifiesChildren within ComputedStyle::ComputeDifference where we don't have the element. Fixed: 513162498 Change-Id: I5332ae59b80bef60ea3ee13af4a69a5aadd4cede
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We recently hardened the code within LayoutBlock::AddChild, see:
https://chromium-review.googlesource.com/c/chromium/src/+/7836695
This revealed that an <mtd> isn't blockifiying its children when it
should be.
<mtd> elements create a special layout object which places all the
children into an anonymous <mrow>. <mrow> children blockified under
normal circumstances.
This patch adds a monotonic_flag to the computed_style object which
forces a style to blockify its children. This is needed (vs. just
making ComputedStyle::BlockifiesChildren take an "const Element&" arg
as we compare BlockifiesChildren within
ComputedStyle::ComputeDifference where we don't have the element.
Fixed: 513162498
Change-Id: I5332ae59b80bef60ea3ee13af4a69a5aadd4cede
Reviewed-on: https://chromium-review.googlesource.com/7853621
WPT-Export-Revision: d9a2948487d9bf926428b780887cafad67fc451f