[Gecko Bug 2037446] Fix computed value testing for offset-rotate keywords#59942
Open
moz-wptsync-bot wants to merge 1 commit into
Open
[Gecko Bug 2037446] Fix computed value testing for offset-rotate keywords#59942moz-wptsync-bot wants to merge 1 commit into
moz-wptsync-bot wants to merge 1 commit into
Conversation
The default keyword testing does not handle the special computed values of offset-rotate correctly. For example, "reverse" computes to "auto 180deg", while "auto" may be exposed as either "auto" or "auto 0deg" depending on the engine. Add custom computed value checks for these keyword cases so the tests match the property-specific computed value behavior. Differential Revision: https://phabricator.services.mozilla.com/D298938 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2037446 gecko-commit: f3c574159a013e064289c870860bfb67ad0178ba gecko-commit-git: 58dc4f5be7b75198c23a35d5423c5df1bb5567cf gecko-reviewers: emilio, firefox-style-system-reviewers
wpt-pr-bot
approved these changes
May 18, 2026
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default keyword testing does not handle the special computed values of
offset-rotate correctly. For example, "reverse" computes to "auto 180deg",
while "auto" may be exposed as either "auto" or "auto 0deg" depending on the
engine.
Add custom computed value checks for these keyword cases so the tests match the
property-specific computed value behavior.
Differential Revision: https://phabricator.services.mozilla.com/D298938
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2037446
gecko-commit: f3c574159a013e064289c870860bfb67ad0178ba
gecko-commit-git: 58dc4f5be7b75198c23a35d5423c5df1bb5567cf
gecko-reviewers: emilio, firefox-style-system-reviewers