Escape media types and features in serialization#60460
Open
chromium-wpt-export-bot wants to merge 1 commit into
Open
Escape media types and features in serialization#60460chromium-wpt-export-bot wants to merge 1 commit into
chromium-wpt-export-bot wants to merge 1 commit into
Conversation
Escaped media features and custom property features were not escaped on serialization. Use SerializeIdentifier() instead of Append(). Bug: 518112775, 517693726 Change-Id: Ibfa43b9a7d925a3efe65049fb80b8309353a46c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7900079 Reviewed-by: Steinar H Gunderson <sesse@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1643107}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-7900079
branch
from
46b58e1 to
37f0458
Compare
wpt-pr-bot
approved these changes
Jun 8, 2026
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Chromium project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Escaped media features and custom property features were not escaped on
serialization. Use SerializeIdentifier() instead of Append().
Bug: 518112775, 517693726
Change-Id: Ibfa43b9a7d925a3efe65049fb80b8309353a46c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7900079
Reviewed-by: Steinar H Gunderson <sesse@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1643107}