layout: Use f64 when blending table content sizes - #61530
Merged
servo-wpt-sync merged 1 commit intoJul 26, 2026
Conversation
wpt-pr-bot
approved these changes
Jul 25, 2026
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Servo project.
It seems that `f32` doesn't have enough precision to prevent hitting our floating point error limit when blending content sizes during table layout. This change makes more calculations use `f64` preventing a debug assertion from firing. Signed-off-by: Martin Robinson <mrobinson@igalia.com>
servo-wpt-sync
force-pushed
the
servo_export_46775
branch
from
July 26, 2026 13:01
1e10a1c to
487384c
Compare
servo-wpt-sync
merged commit Jul 26, 2026
631dbaa
into
web-platform-tests:master
25 of 26 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that
f32doesn't have enough precision to prevent hitting ourfloating point error limit when blending content sizes during table
layout. This change makes more calculations use
f64preventing a debugassertion from firing.
Testing: This change adds a WPT crash test.
Fixes: #46774.
Reviewed in servo/servo#46775