Skip to content

Revert "Fix rtp sender max bitrate" #62110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chromium-wpt-export-bot wants to merge 1 commit into
base: master
Choose a base branch
from
+0 −17
Open

Revert "Fix rtp sender max bitrate" #62110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions webrtc/RTCPeerConnection-addTransceiver.https.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,14 +88,6 @@
assert_throws_js(TypeError, () => pc.addTransceiver('invalid'));
}, 'addTransceiver() with string argument as invalid kind should throw TypeError');

test(t => {
const pc = new RTCPeerConnection();
t.add_cleanup(() => pc.close());
assert_throws_js(RangeError, () => pc.addTransceiver('audio', {
sendEncodings: [{ maxBitrate: 0 }]
}));
}, 'addTransceiver() with maxBitrate set to 0 should throw RangeError');

/*
5.1. addTransceiver
The initial value of mid is null.
Expand Down
9 changes: 0 additions & 9 deletions webrtc/RTCRtpSender-setParameters.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,13 +56,4 @@
}, `setParameters() with already used parameters should reject with InvalidStateError if the event loop has been relinquished`);
}

promise_test(async t => {
const pc = new RTCPeerConnection();
t.add_cleanup(() => pc.close());
const { sender } = pc.addTransceiver('audio');
const param = sender.getParameters();
param.encodings[0].maxBitrate = 0;
await promise_rejects_js(t, RangeError, sender.setParameters(param));
}, `setParameters() with maxBitrate set to 0 should reject with RangeError`);

</script>
Loading