[Gecko Bug 2065425] Don't stretch with indefinite block-size in GenerateFlexItemsForChild. - #62145
Open
moz-wptsync-bot wants to merge 1 commit into
Open
[Gecko Bug 2065425] Don't stretch with indefinite block-size in GenerateFlexItemsForChild.#62145moz-wptsync-bot wants to merge 1 commit into
moz-wptsync-bot wants to merge 1 commit into
Conversation
The key here is not so much the fact that we don't use Stretch() (it wouldn't get used anyhow), but that it causes us to call ResolveStretchedCrossSize() below, even if the resulting cross-size ends up being non-indefinite. Differential Revision: https://phabricator.services.mozilla.com/D320407 bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2065425 gecko-commit: 4c0d2d018641238226e1db60c98426158ec84750 gecko-commit-git: 6f1a348e95a4accc0825a016600c9fd3d8f92547 gecko-reviewers: layout-reviewers, dshin
wpt-pr-bot
approved these changes
Aug 22, 2026
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
Collaborator
There was a problem hiding this comment.
The review process for this patch is being conducted in the Firefox project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The key here is not so much the fact that we don't use Stretch() (it
wouldn't get used anyhow), but that it causes us to call
ResolveStretchedCrossSize() below, even if the resulting cross-size ends
up being non-indefinite.
Differential Revision: https://phabricator.services.mozilla.com/D320407
bugzilla-url: https://bugzilla.mozilla.org/show_bug.cgi?id=2065425
gecko-commit: 4c0d2d018641238226e1db60c98426158ec84750
gecko-commit-git: 6f1a348e95a4accc0825a016600c9fd3d8f92547
gecko-reviewers: layout-reviewers, dshin