fix(recovery): Change initialiseConnection() in XAResourceRecoveryHelper

[danila-m]

• At least on Oracle & Postgres, the connections wrapped inside the XAConnections will automatically timeout after some time.
• When it happens, the recovery mechanism does not detect that the XAConnections need to be closed & recreated (as the objects are not null). This will generate warning logs at regular intervals as the recovery mechanism tries to do its thing on "dead" connections.

This commit improves this behavior by:

• Attempting to properly close the "active" connection&
• then always recreating a connection during the recovery process.

[KarmBot]

Can one of the admins verify this patch? If it is not dangerous to our systems, juts tell me to "run_tests". ( without the underscore and quotes 😃 )

[mmusgrov]

So if I am reading this correctly then every call to getXAResources() will return a fresh connection. I'm not sure who calls it, but I am assuming it is called by the narayana recovery module, which means that each recovery pass will get a fresh resource. I am unclear about the performance impact but safety is more important than performance. On this basis I will confer my approval.

[zhfeng]

yeah, I think you are right.

[zhfeng]

run_tests

[Karm]

run tests

[Karm]

run tests

[Karm]

@danila-m CI failed on

[INFO] Starting audit...
[ERROR] /home/tester/jenkins/workspace/narayana-tomcat/f977fc1d/tomcat-jta/src/main/java/org/jboss/narayana/tomcat/jta/internal/PoolingDataSourceFactory.java:23: Using the '.*' form of import should be avoided - javax.sql.*. [AvoidStarImport]
Audit done.

[Karm]

The CI job needed reconfiguration and it should be fine now.

@zhfeng , if you comment run_tests without the underscore it will run again....

[danila-m]

@danila-m CI failed on

[INFO] Starting audit...
[ERROR] /home/tester/jenkins/workspace/narayana-tomcat/f977fc1d/tomcat-jta/src/main/java/org/jboss/narayana/tomcat/jta/internal/PoolingDataSourceFactory.java:23: Using the '.*' form of import should be avoided - javax.sql.*. [AvoidStarImport]
Audit done.

Done

[Karm]

run tests

[Karm]

@mmadzin @jfclere Could you take it from here, please?
h2 tests passing, but those with real DBs don't, there are obsolete http instead of https URLs used etc.

Unable to collect/resolve dependency tree for a resolution due to: 
Failed to collect dependencies at org.postgresql:postgresql:jar:42.2.2, 
caused by: Server returned HTTP response code: 501 for 
URL: http://repo1.maven.org/maven2/org/postgresql/postgresql/42.2.2/postgresql-42.2.2.pom

(not related to this PR)

The project needs some attention :-)

[mmusgrov]

Hello @Karm I still approve of this change. Will you either merge it or withdraw the PR.

Unable to collect/resolve dependency tree for a resolution due to:
Failed to collect dependencies at org.postgresql:postgresql:jar:42.2.2,
caused by: Server returned HTTP response code: 501 for
URL: http://repo1.maven.org/maven2/org/postgresql/postgresql/42.2.2/postgresql-42.2.2.pom

(not related to this PR)

Is there an issue for this problem?

[Karm]

Hello @mmusgrov,

See #33

I haven't been involved with the project for years now.

@mmadzin, @csutherl or @jfclere could do the merging as they still own the project.

In addition to that, you yourself and @tomjenkinson are both committers on this repo with the power to merge changes.

Cheers
K.