fix: resolve flash screen and relocation issues on CL detail page #1591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the CL (Change List) detail page to address flash screen and relocation issues by extracting inline components into separate files. The Conversation and FileChange components, previously defined within the main page component, have been moved to standalone ConversationTab and FileChangeTab components with React.memo optimization.
Key Changes
- Extracted
ConversationandFileChangeinline components into separate memoized components - Removed 204 lines of inline component code from the main detail page
- Updated imports to reflect the new component locations
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| moon/apps/web/pages/[org]/cl/[link]/index.tsx | Removed inline Conversation and FileChange components; replaced with imports and usage of ConversationTab and FileChangeTab; cleaned up unused imports |
| moon/apps/web/components/ClView/FileChangeTab.tsx | Created new memoized FileChangeTab component wrapping FileDiff |
| moon/apps/web/components/ClView/ConversationTab.tsx | Created new memoized ConversationTab component with all conversation UI logic and sidebar |
benjamin-747
approved these changes
Oct 27, 2025
Merged
via the queue into
web3infra-foundation:main
with commit Oct 27, 2025
9e64336
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve flash screen and relocation issues on CL detail page