Skip to content

Conversation

@AidCheng
Copy link
Contributor

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the is_reviewer function to correctly return false when a reviewer is not found, and updates one call site to use campsite_user_id instead of username for reviewer validation.

  • Fixed logic bug in is_reviewer method to properly return boolean based on reviewer existence
  • Updated review_resolve handler to check reviewer status and return error if user is not a reviewer
  • Changed review_resolve to use campsite_user_id instead of username for reviewer check

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
jupiter/src/storage/cl_reviewer_storage.rs Fixed is_reviewer to return correct boolean value based on query result
mono/src/api/router/cl_router.rs Added reviewer authorization check in review_resolve handler using campsite_user_id

@benjamin-747 benjamin-747 added this pull request to the merge queue Oct 30, 2025
Merged via the queue into web3infra-foundation:main with commit b38beb5 Oct 30, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants