feat: Implement online file editor and Diff preview functionality #1598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
juanlou1217
commented
Oct 29, 2025
juanlou1217
commented
- Provide editing and Diff preview modes
- Support file renaming feature
- Fix blame timeline
- Fix lastCommit avatar display
- Provide editing and Diff preview modes - Support file renaming feature - Fix blame timeline - Fix lastCommit avatar display
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the API types to simplify commit and blame information structures, removing redundant user details in favor of simple usernames, and adds a new blob editing feature with diff preview capabilities.
Key Changes
- Simplified blame and commit information structures by replacing complex user objects with simple username/time fields
- Removed the
UserInfotype and replaced nested objects with string usernames - Added blob editing functionality with a new
BlobEditorcomponent and supporting hooks
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| moon/packages/types/generated.ts | Simplified BlameInfo, CommitBindingResponse, and LatestCommitInfo types; removed UserInfo type |
| moon/apps/web/hooks/useUpdateBlob.ts | New hook for updating blob content with query invalidation |
| moon/apps/web/hooks/useDiffPreview.ts | New hook for generating diff previews |
| moon/apps/web/components/CodeView/CommitHistory.tsx | Updated to use simplified LatestCommitInfo with username strings and fetch member data separately |
| moon/apps/web/components/CodeView/BlobView/CodeContent.tsx | Added edit mode state, BlobEditor integration, and updated blame field references |
| moon/apps/web/components/CodeView/BlobView/BlobEditor.tsx | New component providing inline file editing with diff preview and commit dialog |
| type='text' | ||
| value={editedFileName} | ||
| onChange={(e) => setEditedFileName(e.target.value)} | ||
| placeholder='fileName' |
There was a problem hiding this comment.
Placeholder text should use proper spacing: 'File name' instead of 'fileName' for better user experience.
Suggested change
| placeholder='fileName' | |
| placeholder='File name' |
| type='text' | ||
| value={commitMessage} | ||
| onChange={(e) => setCommitMessage(e.target.value)} | ||
| placeholder={`update ${fileName}`} |
There was a problem hiding this comment.
Placeholder text should be capitalized: 'Update' instead of 'update' to maintain consistency with the commit message label.
Suggested change
| placeholder={`update ${fileName}`} | |
| placeholder={`Update ${fileName}`} |
Co-authored-by: Copilot <[email protected]> Signed-off-by: 卷娄 <[email protected]>
Co-authored-by: Copilot <[email protected]> Signed-off-by: 卷娄 <[email protected]>
benjamin-747
approved these changes
Oct 30, 2025
Merged
via the queue into
web3infra-foundation:main
with commit Oct 30, 2025
d9179c8
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.