feat(build-trigger): trigger build on Buck file upload completion#1947
Merged
benjamin-747 merged 1 commit intoweb3infra-foundation:mainfrom Feb 17, 2026
Merged
Conversation
- Add BuckFileUploadHandler and register it in TriggerRegistry - Add TriggerContext::from_buck_upload and BuckFileUploadPayload - Add trigger_build_for_buck_upload in MonoApiService::complete_buck_upload - Extend CompleteResponse with repo_path and from_hash for trigger context Signed-off-by: Wan Yidong <1360947433yd@gmail.com>
b08d586 to
7672acc
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR integrates Buck file uploads into Mega's explicit build trigger system, addressing issue #1831. Previously, Buck file uploads (via cargo buckal) were not systematically integrated into the unified build trigger model. This PR adds a new BuckFileUploadHandler that triggers builds when Buck files are uploaded, providing the same observability and control as Git push and manual triggers.
Changes:
- Added
BuckFileUploadHandlerto handle Buck file upload build triggers - Extended
CompleteResponsemodel withrepo_pathandfrom_hashfields for build trigger context - Integrated build triggering into
complete_buck_uploadAPI endpoint using async spawn pattern
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ceres/src/build_trigger/buck_upload_handler.rs | New handler implementing TriggerHandler for Buck file uploads, follows established handler pattern with ChangesCalculator |
| ceres/src/build_trigger/mod.rs | Registers BuckFileUploadHandler in TriggerRegistry alongside other trigger handlers |
| ceres/src/build_trigger/model.rs | Updates ListTriggersParams comment to include buck_file_upload in the list of trigger types |
| ceres/src/api_service/mono_api_service.rs | Adds trigger_build_for_buck_upload method and integrates it into complete_buck_upload endpoint |
| ceres/src/model/buck.rs | Extends CompleteResponse with repo_path and from_hash fields needed for trigger context |
benjamin-747
approved these changes
Feb 17, 2026
Merged
via the queue into
web3infra-foundation:main
with commit Feb 17, 2026
dc1f7ee
11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
link #1831