Skip to content

Adding expression level histogram#499

Merged
adit-anand merged 5 commits intodevelopmentfrom
kevzhzh_histogram
Oct 13, 2025
Merged

Adding expression level histogram#499
adit-anand merged 5 commits intodevelopmentfrom
kevzhzh_histogram

Conversation

@ZhenghaoZhu
Copy link
Collaborator

TODO: Write details for implementation

image

@enemeth19
Copy link
Collaborator

I think we should remove the stratification by mutation status in the histogram so that the sole purpose of this plot is filtering based on expression level of the gene - what do you think?

@enemeth19
Copy link
Collaborator

Also, can you add the ability to filter the patient cohort by expression level (i.e., by dragging the cursor to select an area (but, really, a certain x-axis range) of the histogram?

@ZhenghaoZhu
Copy link
Collaborator Author

Added the requested changes
image

@enemeth19
Copy link
Collaborator

This is a pretty plot that functions smoothly. Thanks so much for your work on this, Kevin. A few comments for ways that I think we can improve how it integrates into the rest of the app are below.

  • This plot is visually more complex with more components than the pie chart, but all the components are meaningful, so for now I think we should keep its UI components as is, except for what’s noted below
  • Regarding range slider:
    (1) I think that how it currently works with zooming in on a part of the plot is the default behavior. I think it’d be simpler if, when a user drags their cursor on the plot, instead of zooming in to that area, the bars in that selected area are changed to a different color (e.g., yellow, similar to the pie charts’ behavior which sort of ‘highlights’ the selection that was made).
    (2) I think that if part of a bar is captured in the dragged selection, the patients contained in that whole bar should be included in the selection/filtered down cohort, since the bars represent a binning of the data
  • I think we should disable the bottom gray rectangle for now. I like it, but I think it makes the plot a bit too bulky. Maybe just comment the code lines that produce it and we can revisit it later
  • The layout of all the plots in the data explore section are in disarray with the addition of this expression level plot. If we remove the bottom gray rectangle, maybe this will be restored. If not, then we’ll need to address it, perhaps as a separate issue
  • The cohort filtering intended to occur via selections in the expression level plot doesn’t get passed down to the downstream plots after the submit button. We need to correct this as well

Thank you again, and please let us know your thoughts on these comments! Also happy to discuss a strategy/plan of attack for these changes.

@enemeth19
Copy link
Collaborator

Also, please modify this PR to merge into development branch rather than release branch

- Revert to same bar colors and sizing as clinical feature histograms for uniformity
- Restrict plot selections to only be in horizontal direction (not vertical)
- Disable range slider
- Disable filter status div
@enemeth19 enemeth19 changed the base branch from release to development July 15, 2025 01:10
@enemeth19
Copy link
Collaborator

The above commit to the kevzhzh_histogram branch resolves point (1) described above pertaining to range slider, as well as:

I think we should disable the bottom gray rectangle for now

@enemeth19
Copy link
Collaborator

The above commit to the kevzhzh_histogram branch resolves the following:

The cohort filtering intended to occur via selections in the expression level plot doesn’t get passed down to the downstream plots after the submit button. We need to correct this as well

@enemeth19 enemeth19 requested a review from adit-anand September 7, 2025 05:30
Copy link
Collaborator

@adit-anand adit-anand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge

@adit-anand adit-anand merged commit 21b5332 into development Oct 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants