Skip to content

Install polyfill when upgrade is not a function #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Jeroen-Veltmans
Copy link

Fixes #565

Also check if upgrade is a function in case it is only supported on later browsers than define and get.

@google-cla
Copy link

google-cla bot commented Oct 17, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

stale bot commented Apr 26, 2025

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@MattiasBuelens
Copy link

Our team is still affected by this bug.

@sorvell @justinfagnani Sorry to bother, but could you please take a look at this PR?

@justinfagnani
Copy link
Collaborator

justinfagnani commented Apr 28, 2025

edit: oops, wrong polyfill. I'll try to take a look.

@justinfagnani
Copy link
Collaborator

@MattiasBuelens may I ask what browsers you're running on?

@Jeroen-Veltmans
Copy link
Author

@justinfagnani it's added as part of the ticket. We saw the issue on some smart TVs which use Chrome v56 and v63. According to browser compatibility Chrome versions 54-67 are affected and other platforms like Mac Safari versions 10.1-12.0 should also be affected as the define method is defined but the upgrade method not yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polyfill not loaded when upgrade is not a function
3 participants