Skip to content

feat: Alpha Support for Multi-remote Browser #1985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dprevost-LMI wants to merge 30 commits into
base: main
Choose a base branch
from
Open

feat: Alpha Support for Multi-remote Browser #1985

dprevost-LMI wants to merge 30 commits into from
+2,028 −117

Conversation

@dprevost-LMI
Copy link
Contributor

@dprevost-LMI dprevost-LMI commented Dec 30, 2025 •
edited
Loading

Fixes partially #106

PR serving as a starting point to support the multi-remote case.

  • The goal is to have a strong groundwork and not to implement all matchers in a single PR.
  • The first iteration is to implement the toHaveTitle browser matchers
  • Element's matchers will come next
  • waitUntil was reviewed to support multiple instances better so that we can retry only those that failed, optimizing the fetching process.
    • Also, it now returns a CompareResult to be more flexible and returns more information for the assertions.
  • Mechanism to fetch actual data and to format error message was streamlined using an array of instances (even for non multi-remote case) to have a single algorithm used, but all extensible.
  • Until the work is proven enough, it is kept under the UNSTABLE umbrella, so it is to be used at your own risk.

Next:

Draft TODOs:

  • Code review
  • Add unit tests

@dprevost-LMI dprevost-LMI mentioned this pull request Dec 30, 2025
Closed
@dprevost-LMI dprevost-LMI changed the title feat: WIP Support multiremote feat: WIP Alpha Support for Multiremote Dec 31, 2025
@dprevost-LMI dprevost-LMI changed the title feat: WIP Alpha Support for Multiremote feat: Alpha Support for Multiremote Dec 31, 2025
dprevost-LMI
dprevost-LMI commented Dec 31, 2025
View reviewed changes
dprevost-LMI
dprevost-LMI commented Dec 31, 2025
View reviewed changes
dprevost-LMI
dprevost-LMI commented Dec 31, 2025
View reviewed changes
dprevost-LMI
dprevost-LMI commented Dec 31, 2025
View reviewed changes
@dprevost-LMI dprevost-LMI changed the title feat: Alpha Support for Multiremote feat: Alpha Support for multi-remote Browser Jan 1, 2026
@dprevost-LMI dprevost-LMI changed the title feat: Alpha Support for multi-remote Browser feat: Alpha Support for Multi-remote Browser Jan 1, 2026
@dprevost-LMI dprevost-LMI marked this pull request as ready for review January 2, 2026 13:33
@dprevost-LMI dprevost-LMI mentioned this pull request Jan 3, 2026
Open
christian-bromann
christian-bromann reviewed Jan 4, 2026
View reviewed changes
docs/MultiRemote.md
To assert all remotes with a default value, overriding specific ones:
```ts
await expect(multiRemoteBrowser).toHaveTitle({
default : 'My Default Site Title',
Copy link
Member

@christian-bromann christian-bromann Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does default mean here?

Copy link
Contributor Author

@dprevost-LMI dprevost-LMI Jan 4, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would provide a default value to assert on all remotes. So instead of enumerating them all when you only have one exception, you can still offer one value for all and another for the exception.

dprevost-LMI and others added 16 commits January 5, 2026 07:55
@dprevost-LMI
Draft first working multi-remote case
608b0af 
- Simple working case expecting one value
@dprevost-LMI
useful command to check everything (to revert)
cf8088b
@dprevost-LMI
Working multiple targets and failures
6fd69aa
@dprevost-LMI
Working with multiple provided values
e70bd6b
@dprevost-LMI
Add comment on future plan
2b5b5e5
@dprevost-LMI
Working case of optimize waitUntil running per instance + failure msg
24e7578
@dprevost-LMI
working consolidation of waitUntil + formatFailureMessage
2846f34 
- Use `waitUntilResult` optimize to rerun per instance and now returns results with multiple information easing the processing. Also support condition returning an array of result or an array of promise
- Use `formatFailureMessage` both compatible for multi-remote and not
- Streamline and unify the processing of browser + get of actual value to use same algo to support easier both multi-remote and not multi-remote
@dprevost-LMI
Add doc for supported case for alpha version + some future plan
dbce283
@dprevost-LMI
code review
938f87c
@dprevost-LMI
Add multi-remote alternative doc with Parametrized Tests
665109c
@dprevost-LMI
Add Direct Instance Access alternative + fix english grammar
60d8aa5
@dprevost-LMI
Code review
617a0aa
@dprevost-LMI
Add multi-remote typing support
ea00149
@dprevost-LMI
Add missing unit tests for waitUntilResult
8fd88dd
@dprevost-LMI
fix linting
fc617b8
@dprevost-LMI
add unit test for formatMessage
ce71bd9
dprevost-LMI
dprevost-LMI commented Jan 5, 2026
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@christian-bromann christian-bromann christian-bromann left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dprevost-LMI @christian-bromann