fix: failure msg with enhanceErrorBe + code refactoring simplification
#1987
+921
−294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add toHaveTitle on main so it will be easier to "compare" with multi-remote support changes
- Fix double negation in `Expected` with `isNot` when using `enhanceErrorBe` - Fix incorrect Received value with `isNot` when using `enhanceErrorBe` - Code refactoring simplify to better understand the code
dprevost-LMI
force-pushed
the
fix-enhanceErrorBe-ambigious-isNot-failure-message
branch
from
9c1183e to
cb27d1c
Compare
dprevost-LMI
changed the title
enhanceErrorBe + code refactoring simplificationenhanceErrorBe + code refactoring simplification
Contributor
Author
|
Need to merge #1983 first |
dprevost-LMI
added a commit
to dprevost-LMI/expect-webdriverio
that referenced
this pull request
Jan 5, 2026
Backporting fixes of issue webdriverio#1986 and PR webdriverio#1987 to multi-remote
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1986
ExpectedwithisNotwhen usingenhanceErrorBeisNotwhen usingenhanceErrorBe