fix: Fix matchers not working with $$ aka ElementArray
#1990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dprevost-LMI
force-pushed
the
fix-matchers-with-$$
branch
from
ace6980 to
2937e47
Compare
Even if the typing was passing using `'getElement' in received` was not considering Chainable cases
dprevost-LMI
force-pushed
the
fix-matchers-with-$$
branch
from
811216d to
62a200b
Compare
Speed-up unit tests runs Speed-up test execution
Align code to use same code pattern and fix case of `Element[]` not working
dprevost-LMI
commented
Jan 11, 2026
Comment on lines
+24
to
+25
| - name: Run All Checks | ||
| run: npm run checks:all |
dprevost-LMI
commented
Jan 11, 2026
| return aliasFn.call(this, toExist, { verb: 'be', expectation: 'existing' }, el, options) | ||
| this.verb = 'be' | ||
| this.expectation = 'existing' | ||
| this.matcherName = 'toBeExisting' |
Contributor
Author
There was a problem hiding this comment.
Fixed bad matcher name
dprevost-LMI
commented
Jan 11, 2026
| const attr = await el.getAttribute(attribute) | ||
| if (typeof attr !== 'string') { | ||
| return { result: false, value: attr } | ||
| async function conditionAttributeValueMatchWithExpected(el: WebdriverIO.Element, attribute: string, expectedValue: string | RegExp | WdioAsymmetricMatcher<string>, options: ExpectWebdriverIO.StringOptions) { |
Contributor
Author
There was a problem hiding this comment.
Verify if Array<expectedValue: string | RegExp | WdioAsymmetricMatcher<string>> is need to allow to pass multiple different expected for the $$ support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1507.
Matchers
toBeDisplayedand several others have TypeScript signatures that support an array element, even though they don't.