Skip to content

feat: upgrade to node 22 and yarn 1.22.22 #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brycetham merged 3 commits into from
Apr 23, 2025
Merged

feat: upgrade to node 22 and yarn 1.22.22 #7

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
464e6ba
feat: upgrade to node 22 and yarn 1.22.22
brycetham Apr 22, 2025
362bb5a
chore: remove yarn from devDependencies
brycetham Apr 23, 2025
9b0e352
chore: update yarn.lock
brycetham Apr 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ module.exports = {
],
'jsdoc/require-param-type': 0,
'jsdoc/require-returns-type': 0,
'jsdoc/tag-lines': 0,
'jsdoc/valid-types': 1,
'no-underscore-dangle': 0,
'no-shadow': 0,
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/npm-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
token: ${{ secrets.CI_TOKEN }}
- uses: actions/setup-node@v3
with:
node-version: 16
node-version: 22
- run: yarn install
- run: yarn build
- run: npx semantic-release
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pull-request-checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: '16'
node-version: 22
- run: yarn install
- run: yarn test:lint
- run: yarn test:coverage
4 changes: 2 additions & 2 deletions .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
registry = https://registry.npmjs.org

engine-strict = true
registry = https://registry.npmjs.org
1 change: 1 addition & 0 deletions .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
22
16 changes: 11 additions & 5 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@
},
"repository": "https://github.com/webex/ts-events.git",
"license": "MIT",
"engines": {
"node": ">=22.0.0",
"npm": "please-use-yarn",
"yarn": ">=1.22.0"
},
"devDependencies": {
"@commitlint/cli": "^12.1.4",
"@commitlint/config-conventional": "^12.1.4",
Expand All @@ -34,7 +39,7 @@
"@types/jest": "^27.0.1",
"@types/lodash": "^4.14.171",
"@types/mocha": "^9.0.0",
"@types/node": "^16.0.1",
"@types/node": "^22.0.0",
"@typescript-eslint/eslint-plugin": "^4.28.2",
"@typescript-eslint/parser": "^4.28.2",
"chai": "^4.3.4",
Expand All @@ -44,7 +49,7 @@
"eslint-config-prettier": "^8.3.0",
"eslint-plugin-import": "^2.24.0",
"eslint-plugin-jest": "^24.3.6",
"eslint-plugin-jsdoc": "^35.5.0",
"eslint-plugin-jsdoc": "^43.0.0",
"eslint-plugin-prettier": "^3.4.0",
"husky": "^7.0.0",
"jest": "^27.0.6",
Expand All @@ -68,12 +73,12 @@
"rollup": "^2.53.2",
"rollup-plugin-polyfill-node": "^0.7.0",
"rollup-plugin-terser": "^7.0.2",
"rollup-plugin-typescript2": "^0.30.0",
"rollup-plugin-typescript2": "^0.31.1",
"semantic-release": "^19.0.2",
"ts-jest": "^27.0.5",
"ts-loader": "^9.2.3",
"typescript": "^4.4.3",
"yarn": "^1.22.18"
Copy link
Contributor

@antsukanova antsukanova Apr 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that for web-capabilities there is no yarn in devDependencies, why do we need it here if they follow a similar pattern for publishing?

Copy link
Collaborator Author

@brycetham brycetham Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good point. I don't think it's necessary so I'll remove it.

"yarn": "^1.22.22"
},
"scripts": {
"build": "run-s clean compile",
Expand Down Expand Up @@ -115,5 +120,6 @@
"eslint --max-warnings=0",
"cspell"
]
}
},
"packageManager": "yarn@1.22.22"
}
Loading