feat(ci): add Webex bot to comment SDK version and changelog on merged PRs#4737
feat(ci): add Webex bot to comment SDK version and changelog on merged PRs#4737vamshigovardhana wants to merge 5 commits intowebex:nextfrom
Conversation
22af426 to
e36b017
Compare
e36b017 to
be161d6
Compare
Sends release notifications to a Webex Space after Deploy CD completes. Uses yarn package-tools for recursive package detection. Co-authored-by: Cursor <cursoragent@cursor.com>
Shreyas281299
left a comment
There was a problem hiding this comment.
- Have we tested this?
- Do we have a new bot created for this? And which webex space are we using for this?
| inputs: | ||
| test_version: | ||
| description: 'Test version number (e.g., 3.10.0)' | ||
| required: false | ||
| default: '3.10.0' | ||
| test_pr_number: | ||
| description: 'Test PR number (e.g., 123)' | ||
| required: false | ||
| default: '' |
There was a problem hiding this comment.
I dont think this is required
There was a problem hiding this comment.
I still see these changes
| WEBEX_BOT_TOKEN: ${{ secrets.WEBEX_BOT_TOKEN }} | ||
| WEBEX_ROOM_ID: ${{ secrets.WEBEX_ROOM_ID }} |
There was a problem hiding this comment.
Have we added these secrets?
There was a problem hiding this comment.
@Shreyas281299 Yes I have added that secrets
@Shreyas281299 Yes I have tested these locally and I have created new space for this in webex and added webex bot in to that space |
| inputs: | ||
| test_version: | ||
| description: 'Test version number (e.g., 3.10.0)' | ||
| required: false | ||
| default: '3.10.0' | ||
| test_pr_number: | ||
| description: 'Test PR number (e.g., 123)' | ||
| required: false | ||
| default: '' |
There was a problem hiding this comment.
I still see these changes
| # Calculate stable version (strip -next.X suffix) | ||
| STABLE_VERSION=$(echo "$VERSION_NUMBER" | sed 's/-next\..*//') | ||
|
|
||
| # Build changelog URL | ||
| CHANGELOG_URL="https://web-sdk.webex.com/changelog/?stable_version=${STABLE_VERSION}" | ||
|
|
||
| # Add package parameter | ||
| if [ -n "${PRIMARY_PACKAGE}" ]; then | ||
| ENCODED_PACKAGE=$(node -e "console.log(encodeURIComponent(process.argv[1]))" "${PRIMARY_PACKAGE}") | ||
| CHANGELOG_URL="${CHANGELOG_URL}&package=${ENCODED_PACKAGE}" | ||
| fi | ||
|
|
||
| # Add version parameter | ||
| if [ -n "${VERSION_NUMBER}" ]; then | ||
| CHANGELOG_URL="${CHANGELOG_URL}&version=${VERSION_NUMBER}" | ||
| fi | ||
|
|
||
| echo "🔗 Changelog URL: ${CHANGELOG_URL}" |
There was a problem hiding this comment.
Since we are changing how the URL is created this would again become an issue, and we would end up creating a wrong URL.
By this time our deploy pipeline would have commented the correct cahngelog link. we can fetch that comment from the PR and use it. What do you think?
There was a problem hiding this comment.
@Shreyas281299 if i implement this logic "The Webex space notification workflow fetches the changelog URL from the PR comment posted by the comment-on-prs job in deploy.yml. But since both are triggered after Deploy CD completes, what if the Webex bot runs before the PR comment is posted? Should we add a retry/polling mechanism, or is there a better way to ensure the comment exists first?"
|
Please post the github run that you did for testing here in the PR |
There was a problem hiding this comment.

COMPLETES #https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-761506
This pull request addresses
Adds a new GitHub Actions workflow to send release notifications to a Webex Space
yarn package-tools list --recursivefor accurate package detectionby making the following changes
nextbranchChange Type
The following scenarios were tested
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
Make sure to have followed the contributing guidelines before submitting.