Skip to content

feat(ci): add Webex bot to comment SDK version and changelog on merged PRs#4737

Open
vamshigovardhana wants to merge 5 commits intowebex:nextfrom
vamshigovardhana:webex-space-bot
Open

feat(ci): add Webex bot to comment SDK version and changelog on merged PRs#4737
vamshigovardhana wants to merge 5 commits intowebex:nextfrom
vamshigovardhana:webex-space-bot

Conversation

@vamshigovardhana
Copy link
Contributor

@vamshigovardhana vamshigovardhana commented Feb 23, 2026

COMPLETES #https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-761506

This pull request addresses

Adds a new GitHub Actions workflow to send release notifications to a Webex Space

  • Triggers after Deploy CD workflow completes successfully
  • Uses yarn package-tools list --recursive for accurate package detection
  • Posts SDK version, PR link, and changelog URL to the configured Webex Space

by making the following changes

  1. Workflow triggers after Deploy CD completes on next branch
  2. Extracts version and PR number from the latest git tag
  3. Uses package-tools to detect affected packages (with recursive dependency detection)
  4. Sends a formatted message to the Webex Space via Webex API

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

I certified that

  • I have read and followed contributing guidelines
  • I discussed changes with code owners prior to submitting this pull request
  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

Sends release notifications to a Webex Space after Deploy CD completes.
Uses yarn package-tools for recursive package detection.

Co-authored-by: Cursor <cursoragent@cursor.com>
@vamshigovardhana vamshigovardhana changed the title ci(bot): Add Webex Space release notification workflow feat(ci): add Webe bot to comment SDK version and changelog on merged PRs Feb 23, 2026
@vamshigovardhana vamshigovardhana changed the title feat(ci): add Webe bot to comment SDK version and changelog on merged PRs feat(ci): add Webex bot to comment SDK version and changelog on merged PRs Feb 23, 2026
@Shreyas281299 Shreyas281299 added the validated If the pull request is validated for automation. label Feb 24, 2026
Copy link
Contributor

@Shreyas281299 Shreyas281299 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Have we tested this?
  • Do we have a new bot created for this? And which webex space are we using for this?

Comment on lines +6 to +14
inputs:
test_version:
description: 'Test version number (e.g., 3.10.0)'
required: false
default: '3.10.0'
test_pr_number:
description: 'Test PR number (e.g., 123)'
required: false
default: ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think this is required

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shreyas281299 Yah I will remove it

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see these changes

Comment on lines +101 to +102
WEBEX_BOT_TOKEN: ${{ secrets.WEBEX_BOT_TOKEN }}
WEBEX_ROOM_ID: ${{ secrets.WEBEX_ROOM_ID }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we added these secrets?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shreyas281299 Yes I have added that secrets

@vamshigovardhana
Copy link
Contributor Author

  • Have we tested this?
  • Do we have a new bot created for this? And which webex space are we using for this?

@Shreyas281299 Yes I have tested these locally and I have created new space for this in webex and added webex bot in to that space

@Shreyas281299
Copy link
Contributor

Screenshot 2026-03-11 at 9 35 30 AM

We are printing UUIDs in the logs please remove it

Comment on lines +6 to +14
inputs:
test_version:
description: 'Test version number (e.g., 3.10.0)'
required: false
default: '3.10.0'
test_pr_number:
description: 'Test PR number (e.g., 123)'
required: false
default: ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still see these changes

Comment on lines +110 to +127
# Calculate stable version (strip -next.X suffix)
STABLE_VERSION=$(echo "$VERSION_NUMBER" | sed 's/-next\..*//')

# Build changelog URL
CHANGELOG_URL="https://web-sdk.webex.com/changelog/?stable_version=${STABLE_VERSION}"

# Add package parameter
if [ -n "${PRIMARY_PACKAGE}" ]; then
ENCODED_PACKAGE=$(node -e "console.log(encodeURIComponent(process.argv[1]))" "${PRIMARY_PACKAGE}")
CHANGELOG_URL="${CHANGELOG_URL}&package=${ENCODED_PACKAGE}"
fi

# Add version parameter
if [ -n "${VERSION_NUMBER}" ]; then
CHANGELOG_URL="${CHANGELOG_URL}&version=${VERSION_NUMBER}"
fi

echo "🔗 Changelog URL: ${CHANGELOG_URL}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are changing how the URL is created this would again become an issue, and we would end up creating a wrong URL.

By this time our deploy pipeline would have commented the correct cahngelog link. we can fetch that comment from the PR and use it. What do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shreyas281299 if i implement this logic "The Webex space notification workflow fetches the changelog URL from the PR comment posted by the comment-on-prs job in deploy.yml. But since both are triggered after Deploy CD completes, what if the Webex bot runs before the PR comment is posted? Should we add a retry/polling mechanism, or is there a better way to ensure the comment exists first?"

@Shreyas281299
Copy link
Contributor

Please post the github run that you did for testing here in the PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

validated If the pull request is validated for automation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants