fix(ci): fix changelog link in the Github-bot#4739
fix(ci): fix changelog link in the Github-bot#4739vamshigovardhana wants to merge 1 commit intowebex:nextfrom
Conversation
vamshigovardhana
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 154fe1cb58
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: adc729c74c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 986d420e6e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
vamshigovardhana
force-pushed
the
bot-comment
branch
2 times, most recently
from
e8099a8 to
1466c7d
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1466c7d336
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b5057218ae
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: af37bf6b66
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
.github/workflows/pr-comment-bot.yml
Outdated
| const prNumber = prNumbers[0]; | ||
| console.log(`Posting comment to PR #${prNumber}`); | ||
| try { | ||
| const commitsRaw = `${{ steps.get-prs.outputs.commits }}`; |
There was a problem hiding this comment.
${{ steps.get-prs.outputs.commits }} is injected into a JavaScript template literal before JSON.parse, so commit subjects containing backticks or ${...} still break script parsing and abort comment posting; this is a realistic input (the repo history already includes backticks in commit titles). Pass the JSON via environment/input encoding rather than source interpolation to keep parsing robust.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a125197b0c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
.github/workflows/pr-comment-bot.yml
Outdated
| # Get packages with --recursive to include dependent packages (like webex) | ||
| # This ensures that if @webex/plugin-meetings changes, webex is also detected | ||
| if [ -n "$PREVIOUS_TAG" ]; then | ||
| PACKAGES=$(yarn package-tools list --recursive --since "$PREVIOUS_TAG" 2>/dev/null || echo "webex") |
There was a problem hiding this comment.
Get Merged PRs intentionally computes PRs from github.event.workflow_run.head_sha, but package detection still runs yarn package-tools list --since "$PREVIOUS_TAG" against the checked-out workspace state. When that checkout commit differs from the workflow run head SHA (the exact mismatch this workflow already guards against for PR lookup), the comment can combine PRs from one release with package metadata from another, producing incorrect "Packages updated" content and changelog package links.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb9f0daaf5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
.github/workflows/pr-comment-bot.yml
Outdated
| echo "📦 Tag: ${VERSION}, PR: #${PR_NUMBER}" | ||
| # Production mode: get real version from package-tools | ||
| yarn ws:tools | ||
| VERSION=$(yarn package-tools sync --tag next --packages webex | awk '{print $3}' | tr -d '%') |
There was a problem hiding this comment.
Calling yarn package-tools sync --tag next --packages webex here mutates the checkout before later steps run: sync calls pack.apply() (packages/tools/package/src/commands/sync/sync.ts) and Package.apply() rewrites package.json (packages/tools/package/src/models/package/package.ts). When the npm next dist-tag differs from the checked-out webex version, this step dirties the worktree, so the subsequent package-tools list --since ... can treat those local edits as changed packages and post incorrect package/changelog metadata for the release.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3ca17d8d4f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
.github/workflows/pr-comment-bot.yml
Outdated
| if: ${{ github.event_name != 'workflow_dispatch' }} | ||
| run: yarn workspaces foreach --from '@webex/*-tools' --topological-dev --parallel --verbose run build:src |
There was a problem hiding this comment.
The Build Tools step is explicitly skipped for workflow_dispatch, but Get Changed Packages still runs yarn package-tools list; webex-package-tools requires ./dist/module (packages/tools/package/index.js), and that dist output is not committed, so manual runs hit a runtime failure and fall back to echo "webex". As a result, manually triggered comments can consistently publish incorrect package/changelog metadata instead of the real changed package set.
Useful? React with 👍 / 👎.
Shreyas281299
added
the
validated
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ca70f35858
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const packages = packagesRaw | ||
| .replace(/[{}]/g, '') | ||
| .split(',') |
There was a problem hiding this comment.
INPUT_PACKAGES here is wired to needs.generate-package-matrix.outputs.node-recursive, which is produced by yarn package-tools list --mode node and therefore emits package names separated by spaces (see packages/tools/package/src/commands/list/list.ts, packageNames.join(' ')). Splitting only on commas turns multi-package outputs like webex @webex/calling into a single entry, so packages.includes('webex') fails and both the "Packages updated" text and changelog package query can be wrong for normal multi-package releases.
Useful? React with 👍 / 👎.
mkesavan13
left a comment
mkesavan13
left a comment
There was a problem hiding this comment.
I feel this PR is not addressing the gap we have today rather taking a whole new route.
@vamshigovardhana - Kindly review the whole code by yourself once and come up with things that seems unnecessary or diverting.
| if (alreadyCommented) { | ||
| console.log(`Already commented on PR #${prNumber} for ${version}`); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Why do we need this step?
There was a problem hiding this comment.
@mkesavan13 This is a safety check to prevent duplicate comments.
There was a problem hiding this comment.
Is there a scenario where duplicate commenting is expected?
| git push origin ${{ steps.versionextractor.outputs.version }} | ||
| fi | ||
|
|
||
| comment-on-prs: |
There was a problem hiding this comment.
If we have everything we need to comment on PRs in deploy.yml now, why do we need pr-comment-bot.yml?
There was a problem hiding this comment.
If we have everything we need to comment on PRs in deploy.yml now, why do we need pr-comment-bot.yml?
@mkesavan13 You're right, we don't need it anymore. I'll delete pr-comment-bot.yml since the logic has moved into the Deploy CD pipeline.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: df83298c4e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| - name: Get Pull Request Number | ||
| id: pr | ||
| run: echo "pull_request_number=$(gh pr view --json number -q .number || echo "")" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
This job runs on push to next, but gh pr view --json number -q .number is invoked without a PR/branch argument, so it resolves the PR for the currently checked-out branch (next) rather than the PR that introduced the pushed commit. In typical merge-to-next runs there is no PR for next, so pull_request_number is empty and the comment step is skipped entirely; if a long-lived PR from next exists, the bot can comment on that unrelated PR instead. Resolve PRs from the push commit SHA (or merge metadata) so comments target the released PR reliably.
Useful? React with 👍 / 👎.
| if (alreadyCommented) { | ||
| console.log(`Already commented on PR #${prNumber} for ${version}`); | ||
| return; | ||
| } |
There was a problem hiding this comment.
Is there a scenario where duplicate commenting is expected?
| const stableVersion = versionNumber.replace(/-next\..*$/, ''); | ||
| const changelogUrl = `https://web-sdk.webex.com/changelog/?stable_version=${stableVersion}&package=${primaryPackage}&version=${versionNumber}`; |
There was a problem hiding this comment.
How does this fix the problem we had of choosing packages[0] while version number was different?
There was a problem hiding this comment.
I've updated the approach. Instead of hardcoding --packages webex for the version, I added a new changedpackage step in publish-tag that first picks the package (prefers webex if it's in the changed list, otherwise uses the first changed package), then fetches that same package's version from NPM. Both package_name and package_version are derived from the same variable ($PKG), so the version always corresponds to the selected package. This eliminates the mismatch we had before where the version came from webex but the package could be something else.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 952c81e722
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| if echo "$CLEAN" | tr ',' '\n' | grep -q "^webex$"; then | ||
| PKG="webex" | ||
| else | ||
| PKG=$(echo "$CLEAN" | tr ',' '\n' | head -1 | tr -d ' ') |
There was a problem hiding this comment.
needs.generate-package-matrix.outputs.node-recursive comes from yarn package-tools list --mode node, which emits package names space-delimited, but this step treats the value as comma-delimited and then strips spaces; for multi-package outputs like webex @webex/calling, PKG becomes webex@webex/calling. That invalid package name causes yarn package-tools sync --packages $PKG to resolve no workspace and produce an empty version, so downstream PR comments are posted with package_version set to just v and broken release/changelog links.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 449ba90df4
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
.github/workflows/deploy.yml
Outdated
| always() && | ||
| needs.generate-package-matrix.result == 'success' && | ||
| needs.generate-package-matrix.outputs.node-recursive != '' |
There was a problem hiding this comment.
This job is allowed to run with always() and only checks generate-package-matrix, so it still executes when publish-tag fails (for example, tag push/API failures) and can post "Your changes are now available" even though the release did not complete. In that failure path, INPUT_VERSION also falls back to a placeholder, so contributors can receive a false production-release notification; gate this job on needs.publish-tag.result == 'success' (and ideally needs.publish-tag.outputs.proceed == 'true').
Useful? React with 👍 / 👎.
.github/workflows/deploy.yml
Outdated
| if: ${{ steps.pr.outputs.pull_request_number != '' }} | ||
| uses: actions/github-script@v7 | ||
| env: | ||
| INPUT_VERSION: ${{ needs.publish-tag.outputs.package_version || 'v0.0.0-dry-run' }} |
There was a problem hiding this comment.
INPUT_VERSION is sourced from publish-tag.outputs.package_version, but the workflow’s Git tag/release is computed from the versionextractor (webex) version, not the selected package version. When the chosen package is not webex (or package dist-tags diverge), the comment’s "Released in" link and changelog version query can point to a non-existent release version, producing broken or misleading metadata.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2846d2e977
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
.github/workflows/deploy.yml
Outdated
| if: | | ||
| always() && | ||
| needs.generate-package-matrix.result == 'success' && | ||
| needs.generate-package-matrix.outputs.node-recursive != '' |
There was a problem hiding this comment.
This job is forced to run via always() and only checks generate-package-matrix, so it still executes when publish-npm/publish-tag fails or is skipped. In those failure paths the comment step can still post a "released" message (using fallback values), which tells contributors their change is live even though the release pipeline did not complete successfully. Add a needs.publish-tag.result == 'success' guard (or equivalent) before posting comments.
Useful? React with 👍 / 👎.
.github/workflows/deploy.yml
Outdated
| if: ${{ steps.pr.outputs.pull_request_number != '' }} | ||
| uses: actions/github-script@v7 | ||
| env: | ||
| INPUT_VERSION: ${{ needs.publish-tag.outputs.package_version || 'v0.0.0-dry-run' }} |
There was a problem hiding this comment.
INPUT_VERSION is sourced from package_version, but the GitHub tag in this workflow is derived from publish-tag's tag version output. When a release updates a non-webex package, package_version can differ from the created tag (or no new tag is created), so the comment's release/changelog links point at a non-existent version. Use the tag version output for link construction, or skip link posting when no tag was produced.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a49b2c0402
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
.github/workflows/deploy.yml
Outdated
| always() && | ||
| needs.generate-package-matrix.result == 'success' && | ||
| (needs.generate-package-matrix.outputs.node-recursive != '' || inputs.pr_number != '') |
There was a problem hiding this comment.
The comment-on-prs job is forced by always() and only checks generate-package-matrix, so it can still post “Your changes are now available” when publish-npm/publish-tag failed or was skipped, using fallback values instead of an actual released tag. In push-triggered failures this sends false release notifications to PRs; add a success guard for needs.publish-tag.result before posting comments.
Useful? React with 👍 / 👎.
.github/workflows/deploy.yml
Outdated
| if: ${{ steps.pr.outputs.pull_request_number != '' }} | ||
| uses: actions/github-script@v7 | ||
| env: | ||
| INPUT_VERSION: ${{ needs.publish-tag.outputs.package_version || 'v0.0.0-dry-run' }} |
There was a problem hiding this comment.
The comment step sets INPUT_VERSION from package_version, but this workflow creates/pushes tags from versionextractor (the release tag version). When the selected package differs from webex, the generated “Released in” link can target a non-existent releases/tag/<package_version> and misreport the actual release artifact. Use the publish-tag version output for the release URL and keep package version separate for package/changelog details.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 601ced18f3
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
.github/workflows/deploy.yml
Outdated
| always() && | ||
| needs.generate-package-matrix.result == 'success' && | ||
| (needs.generate-package-matrix.outputs.node-recursive != '' || inputs.pr_number != '') |
There was a problem hiding this comment.
This job runs under always() and only requires generate-package-matrix to succeed, so it can still execute after publish-npm/publish-tag failures and post "Your changes are now available" even though the release did not complete; in that failure path, INPUT_VERSION falls back to test/default values, which makes the comment content and release link incorrect for production push runs. Restrict this job to successful publish/tag outcomes (or explicitly branch to test-only behavior for workflow_dispatch) before posting user-facing release comments.
Useful? React with 👍 / 👎.
vamshigovardhana
force-pushed
the
bot-comment
branch
from
a3a4cc4 to
95293cb
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a3a4cc48bc
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
.github/workflows/deploy.yml
Outdated
| always() && | ||
| needs.generate-package-matrix.result == 'success' && | ||
| (needs.generate-package-matrix.outputs.node-recursive != '' || inputs.pr_number != '') |
There was a problem hiding this comment.
This job is configured with always() and only checks generate-package-matrix, so it still runs when publish-npm/publish-tag fails or is skipped on a real push release run. In that failure path the comment step can still post "Your changes are now available" using fallback values (for example v0.0.0-dry-run from INPUT_VERSION), which produces false release notifications and broken links for contributors even though the publish did not complete.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 95293cb21c
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| uses: actions/checkout@v3 | ||
| with: | ||
| fetch-depth: 0 |
There was a problem hiding this comment.
In .github/workflows/webex-space-bot.yml, the workflow_run path checks out the repo without a ref and then derives VERSION from git describe --tags; that makes the selected tag depend on whatever commit was checked out rather than the Deploy CD run’s head commit. When the checked-out ref differs (for example, default branch or a newer commit), the bot can announce the wrong release/PR/changelog in Webex. Pin checkout to github.event.workflow_run.head_sha (or resolve tags from that SHA) before extracting tag metadata.
Useful? React with 👍 / 👎.
| exit 1 | ||
| fi | ||
| TAG_MESSAGE=$(git tag -l --format='%(contents:subject)' "$VERSION") | ||
| PR_NUMBER=$(echo "$TAG_MESSAGE" | grep -oE '#[0-9]+' | head -1 | tr -d '#') |
There was a problem hiding this comment.
The PR extraction command uses grep -oE '#[0-9]+' | head -1, which picks the first #<number> anywhere in the tag message subject. If the subject includes other references (for example issue IDs or revert subjects with multiple PR numbers), this will target the wrong PR and then compute package/changelog context from unrelated changes. Parse only the final merge trailer PR token (or map by commit SHA) to avoid misdirected notifications.
Useful? React with 👍 / 👎.
| const existingComments = await github.rest.issues.listComments({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| issue_number: prNumber | ||
| }); |
There was a problem hiding this comment.
The duplicate-check only inspects the single page returned by issues.listComments, but that API returns 30 comments by default. On PRs with more comments, an existing bot release comment can be outside this page, so reruns post duplicate “Your changes are now available” messages. Use github.paginate (or explicit paging) when searching existing comments.
Useful? React with 👍 / 👎.
vamshigovardhana
force-pushed
the
bot-comment
branch
from
95293cb to
c1d8573
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c1d8573fe7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const existingComments = await github.rest.issues.listComments({ | ||
| owner: context.repo.owner, | ||
| repo: context.repo.repo, | ||
| issue_number: prNumber | ||
| }); |
There was a problem hiding this comment.
This script performs issues.listComments/issues.createComment without any error handling, so transient GitHub API failures (rate limiting, token permission changes, or temporary API errors) will throw and fail the entire Deploy CD workflow even though package publish/tagging has already completed. Because this comment job now runs inline in deploy, a non-critical notification failure can incorrectly mark production deploys as failed; wrap the API section in try/catch (or continue-on-error) to keep deploy status reliable.
Useful? React with 👍 / 👎.
Shreyas281299
left a comment
Shreyas281299
left a comment
There was a problem hiding this comment.
Can we post the testing github run here
3 participants
COMPLETES #< https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-754634 >
This pull request addresses
The Git-hub-bot's package detection was inaccurate because it used manual parsing instead of the existing package-tools CLI, which has better support for detecting affected packages and their dependents.
by making the following changes
Replaced manual parsing logic with
yarn package-toolsfor package detection--recursiveflag to detect dependent packages (e.g., if@webex/plugin-meetingschanges,webexis also detected)Change Type
The following scenarios were tested
Vidcast :https://app.vidcast.io/share/281813d7-d374-432f-af52-e4944e7463e3
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
Make sure to have followed the contributing guidelines before submitting.