Skip to content

fix(ca): send stayLobbyTime with lobby exit event#4744

Open
jor-row wants to merge 4 commits intowebex:nextfrom
jor-row:fix/send-staylobbytime-on-lobby-exit
Open

fix(ca): send stayLobbyTime with lobby exit event#4744
jor-row wants to merge 4 commits intowebex:nextfrom
jor-row:fix/send-staylobbytime-on-lobby-exit

Conversation

@jor-row
Copy link
Contributor

@jor-row jor-row commented Feb 25, 2026

COMPLETES https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-603148

This pull request addresses

stayLobbyTime being sent before lobby is exited

by making the following changes

only send this latency with client.lobby.exited event. this means it will only be populated on join result if lobby was actually entered.

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >

The GAI Coding Policy And Copyright Annotation Best Practices

  • GAI was not used (or, no additional notation is required)
  • Code was generated entirely by GAI
  • GAI was used to create a draft that was subsequently customized or modified
  • Coder created a draft manually that was non-substantively modified by GAI (e.g., refactoring was performed by GAI on manually written code)
  • Tool used for AI assistance (GitHub Copilot / Other - specify)
    • Github Copilot
    • Other - Please Specify
  • This PR is related to
    • Feature
    • Defect fix
    • Tech Debt
    • Automation

I certified that

  • I have read and followed contributing guidelines
  • I discussed changes with code owners prior to submitting this pull request
  • I have not skipped any automated checks
  • All existing and new tests passed
  • I have updated the documentation accordingly

Make sure to have followed the contributing guidelines before submitting.

@jor-row jor-row requested review from a team as code owners February 25, 2026 22:36
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e81a969c8c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@jor-row jor-row added the validated If the pull request is validated for automation. label Feb 26, 2026
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8b6b720b00

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +307 to +310
if (ignoreMissingEndEvent && !this.latencyTimestamps.get('client.lobby.exited')) {
this.saveTimestamp({
key: 'client.lobby.exited',
});

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Avoid persisting synthetic lobby-exit timestamp

This branch mutates shared latency state by writing client.lobby.exited = now when the event timestamp is missing, which can happen when queued/retried client.lobby.exited items are prepared after latencies were cleared (fresh evidence: batcher.js re-invokes prepareItem() in rerequest(), and prepareDiagnosticMetricItem() calls getStayLobbyTime(true) for that event). Once this synthetic timestamp is stored, later calls like getTotalMediaJMT()/getInterstitialToMediaOKJMT() can subtract an unrelated lobby duration and report clamped/incorrect media latencies for subsequent meetings.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

validated If the pull request is validated for automation.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants