feat(plugin-meetings): update with media-core, web-capabilities#4750
Draft
fnowakow wants to merge 3 commits intowebex:nextfrom
Draft
feat(plugin-meetings): update with media-core, web-capabilities#4750fnowakow wants to merge 3 commits intowebex:nextfrom
fnowakow wants to merge 3 commits intowebex:nextfrom
Conversation
2e4ac7c to
9b13c31
Compare
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
antsukanova
reviewed
Mar 6, 2026
| }); | ||
| }); | ||
|
|
||
| describe('#checkH264Support', () => { |
Contributor
There was a problem hiding this comment.
I believe could be nice to have additional tests for next things here if we addng tests for this method:
- No
MEDIA_CODEC_MISSINGre-triggered logic MEDIA_CODEC_LOADEDfires when codec becomes available- Logger calls for loaded/missing messages
68a6ac0 to
7d77955
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
COMPLETES SPARK-782508
This pull request addresses
Multistream/codec work requires a single source of truth for codec support detection. The plugin-meetings package previously used its own RTCPeerConnection-based H.264 detection logic, which duplicated logic and created unnecessary peer connections. This PR migrates H.264 support detection to use
@webex/web-capabilities, which is the canonical capability detection layer for Webex web clients.by making the following changes
meetings/util.ts
CapabilityStateandWebCapabilitiesfrom@webex/web-capabilitiesMeetingsUtil.hasH264Codec(RTCPeerConnection + SDP parsing implementation)checkH264Supportto use synchronousWebCapabilities.isCapableOfReceivingVideoCodec('video/H264') === CapabilityState.CAPABLEinstead of asynchasH264Codec()disableNotificationsis true, return immediately without performing any codec check (no "start H.264 download" behavior)media:codec:missing/media:codec:loaded) and timing/retry behavior (5s delay, 5min max duration)test/unit/spec/meetings/utils.js
#checkH264Support:disableNotificationsis trueMEDIA_CODEC_LOADEDwhen H.264 is capableMEDIA_CODEC_MISSINGand schedules retry when H.264 is not capableWebCapabilities.isCapableOfReceivingVideoCodec; no RTCPeerConnection usage in testsDependencies:
@webex/web-capabilities(^1.9.0) and@webex/internal-media-core(2.22.1) are already present in package.json; no changes required.Change Type
The following scenarios were tested
yarn buildinpackages/@webex/plugin-meetings— passesyarn test:style— no new lint issues in changed filesyarn test:unit— all meetings unit tests pass (224 passing), including 4 new#checkH264Supporttestsmedia:codec:missingandmedia:codec:loadedevents fire correctly via stubbedWebCapabilities.isCapableOfReceivingVideoCodecThe GAI Coding Policy And Copyright Annotation Best Practices
I certified that
Make sure to have followed the contributing guidelines before submitting.