feat(contact-center): Dial number validation supports international#4759
feat(contact-center): Dial number validation supports international#4759zachraymer wants to merge 2 commits intowebex:nextfrom
Conversation
…ns US format for fallback
zachraymer
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6283a358a8
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
Kesari3008
left a comment
Kesari3008
left a comment
There was a problem hiding this comment.
Approving with one minor comment
rarajes2
left a comment
rarajes2
left a comment
There was a problem hiding this comment.
Approving with some minor comments
packages/@webex/contact-center/test/unit/spec/services/core/Utils.ts
Outdated
Show resolved
Hide resolved
| INVALID_DIAL_NUMBER: { | ||
| message: | ||
| 'Enter a valid US dial number. For help, reach out to your administrator or support team.', | ||
| 'Enter a valid dial number. For help, reach out to your administrator or support team.', |
There was a problem hiding this comment.
Should we include the supported country list here?
There was a problem hiding this comment.
Thank you for the review Rajesh. Can we satisfy this item or go forward with merge?
packages/@webex/contact-center/test/unit/spec/services/core/Utils.ts
Outdated
Show resolved
Hide resolved
3 participants
COMPLETES #https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7303
This pull request addresses
< DESCRIBE THE CONTEXT OF THE ISSUE >
Changes the dial number validation logic to use dial number entries and match at least one available regex pattern if present, otherwise we retain the previous validation which matches US and canada dial formats.
Feature has been covered by unit testing, and manually verified by e2e testing of SDK -> widgets -> consuming app
by making the following changes
< DESCRIBE YOUR CHANGES >
Vidcast demonstrating changes
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that
Make sure to have followed the contributing guidelines before submitting.