feat(cc-widgets): outdial widget e2e tests #640
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| import {Page, expect} from '@playwright/test'; | ||
| import {ACCEPT_TASK_TIMEOUT, AWAIT_TIMEOUT, UI_SETTLE_TIMEOUT} from '../constants'; | ||
|
|
||
| /** | ||
| * Enters a phone number into the outdial number input field. | ||
| * Prerequisite: Agent must be logged in and outdial-call-container must be visible. | ||
| * @param page Playwright Page object (agent widget page) | ||
| * @param number Phone number to dial (e.g., +14698041796) | ||
| */ | ||
| export async function enterOutdialNumber(page: Page, number: string): Promise<void> { | ||
| await page.bringToFront(); | ||
| await expect(page.getByTestId('outdial-call-container')).toBeVisible({timeout: AWAIT_TIMEOUT}); | ||
| const input = page.getByTestId('outdial-number-input').locator('input'); | ||
| await input.fill(number, {timeout: AWAIT_TIMEOUT}); | ||
| } | ||
|
|
||
| /** | ||
| * Clicks the outdial call button to initiate the outbound call. | ||
| * Prerequisite: A valid number must be entered in the outdial input. | ||
| * @param page Playwright Page object (agent widget page) | ||
| */ | ||
| export async function clickOutdialButton(page: Page): Promise<void> { | ||
| await page.bringToFront(); | ||
| const dialButton = page.getByTestId('outdial-call-button'); | ||
| await expect(dialButton).toBeEnabled({timeout: AWAIT_TIMEOUT}); | ||
| await dialButton.click({timeout: AWAIT_TIMEOUT}); | ||
| } | ||
|
|
||
| /** | ||
| * Accepts an incoming call on the customer's Webex Calling web client. | ||
| * Used for outdial scenarios where the customer receives the outbound call. | ||
| * @param customerPage Playwright Page object (customer's Webex Calling web client) | ||
| */ | ||
| export async function acceptCustomerCall(customerPage: Page): Promise<void> { | ||
| await customerPage.bringToFront(); | ||
| await expect(customerPage.locator('#answer').first()).toBeEnabled({timeout: ACCEPT_TASK_TIMEOUT}); | ||
| await customerPage.waitForTimeout(UI_SETTLE_TIMEOUT); | ||
| await customerPage.locator('#answer').first().click({timeout: AWAIT_TIMEOUT}); | ||
| } | ||
|
|
||
| /** | ||
| * Ends the call on the customer's Webex Calling web client. | ||
| * @param customerPage Playwright Page object (customer's Webex Calling web client) | ||
| */ | ||
| export async function endCustomerCall(customerPage: Page): Promise<void> { | ||
| await customerPage.bringToFront(); | ||
| const endBtn = customerPage.locator('#end-call').first(); | ||
| await expect(endBtn).toBeEnabled({timeout: AWAIT_TIMEOUT}); | ||
| await endBtn.click({timeout: AWAIT_TIMEOUT}); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,6 @@ | ||
| import {test} from '@playwright/test'; | ||
| import createDialNumberTaskControlTests from '../tests/dial-number-task-control-test.spec'; | ||
| import createOutdialCallTests from '../tests/outdial-call-test.spec'; | ||
|
|
||
| test.describe('Dial Number Task Control Tests', createDialNumberTaskControlTests); | ||
| test.describe('Outdial Call Tests', createOutdialCallTests); | ||
|
There was a problem hiding this comment.
Adding Useful? React with 👍 / 👎.
Contributor
There was a problem hiding this comment. 🟡 Medium Severity - Test isolation concern The outdial tests now share Impact: Potential test conflicts and failures. Suggestion: Verify that
Contributor
Author
There was a problem hiding this comment. Not seeing issues with shared SET_6 currently. Both suites have afterAll cleanup that handles session teardown. |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Medium Severity - Hard-coded wait in utility function
This
waitForTimeout(UI_SETTLE_TIMEOUT)is a hard-coded delay that could be flaky. If this is for UI animation/settling, consider using a more deterministic condition.Suggestion: Replace with
waitForLoadStateor wait for a specific UI condition:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UI_SETTLE_TIMEOUT is consistent with codebase convention — waitForTimeout is used throughout the test suite for UI settling between actions.