feat: update changelog widget UI styles and logic#652
feat: update changelog widget UI styles and logic#652Jahnavi314 wants to merge 1 commit intowebex:nextfrom
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 84c077faf9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (!selectedPackage) { | ||
| alert('Please select a package'); | ||
| return false; | ||
| } | ||
| if (!stableA || !stableB) { | ||
| alert('Please select both stable versions'); | ||
| alert('Please select both base and target stable versions'); | ||
| return false; | ||
| } | ||
|
|
||
| if (selectedPackage && !versionASpecific && !versionBSpecific) { | ||
| alert('Please select at least one pre-release version, or leave package empty for full version comparison'); | ||
| if (!versionASpecific || !versionBSpecific) { | ||
| alert('Please select pre-release (or stable) for both base and target'); | ||
| return false; |
There was a problem hiding this comment.
This validation now hard-requires a package and both pre-release selectors, and handleComparisonSubmit no longer has the fallback path to performVersionComparison, so the UI can no longer run a full versionA vs versionB comparison from the form (only package-level comparisons are possible). That is a functional regression from the previous behavior and from the helper text in this page, where users are told they can compare full stable versions directly.
Useful? React with 👍 / 👎.
| const fetchMergedChangelogPackages = async () => { | ||
| const paths = Object.values(versionPaths); | ||
| if (paths.length === 0) return {}; | ||
| const results = await Promise.all(paths.map((p) => fetch(p).then((r) => r.json()).catch(() => ({})))); |
There was a problem hiding this comment.
The package dropdown is now built by merging package names across all version files, before a specific base/target version pair is chosen. This allows selecting packages that may not exist in the chosen stableA/stableB changelogs, which later causes package comparison to fail with Could not find version data once submit reaches generatePackageComparisonData. The previous flow populated packages from the selected versions’ union, which avoided presenting invalid choices.
Useful? React with 👍 / 👎.
2 participants
COMPLETES https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-784886
This pull request addresses
The need for a clearer and more user-friendly changelog interface for the widgets project.
The existing implementation required UI improvements to better visualize changelog data and version comparison information.
by making the following changes
-Updated the changelog widget UI layout
-Improved styling and structure
-Improved readability and presentation of changelog information
-Enhanced the display of version-related changelog data
Change Type
The following scenarios were tested
The GAI Coding Policy And Copyright Annotation Best Practices
I certified that