Skip to content

fix: Reuse HttpClient instance instead of creating one per authorize … #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vikshab wants to merge 1 commit into from
Closed

fix: Reuse HttpClient instance instead of creating one per authorize … #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/main/java/tech/stackable/druid/opaauthorizer/OpaAuthorizer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,12 @@ public class OpaAuthorizer implements Authorizer {
private static final Logger LOG = new Logger(OpaAuthorizer.class);
private final String opaUri;
private final ObjectMapper objectMapper;
private final HttpClient httpClient;

@JsonCreator
public OpaAuthorizer(@JsonProperty("name") String name, @JsonProperty("opaUri") String opaUri) {
this.opaUri = opaUri;
this.httpClient = HttpClient.newHttpClient();
objectMapper =
new ObjectMapper()
// https://github.com/stackabletech/druid-opa-authorizer/issues/72
Expand All @@ -53,8 +55,7 @@ public Access authorize(
return new Access(false, "Failed to create the OPA request JSON: " + e);
}

LOG.trace("Creating HTTP Client and executing post.");
var client = HttpClient.newHttpClient();
LOG.trace("Executing post.");
try {
var request =
HttpRequest.newBuilder()
Expand All @@ -63,7 +64,7 @@ public Access authorize(
.POST(HttpRequest.BodyPublishers.ofString(msgJson))
.build();

var response = client.send(request, HttpResponse.BodyHandlers.ofString());
var response = httpClient.send(request, HttpResponse.BodyHandlers.ofString());

LOG.debug("OPA Response code: %s - %s", response.statusCode(), response.body());
LOG.trace("Parsing OPA response.");
Expand Down
Loading