Skip to content

Reland "Show error dialog on unhandled rejection and uncaught exception" #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025
Merged

Reland "Show error dialog on unhandled rejection and uncaught exception" #510

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9e2d6c
Reland "Show error dialog on unhandled rejection and uncaught excepti…
kainino0x Apr 21, 2025
cfbd50a
undo unrelated nits
kainino0x Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions sample/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,14 @@
// Show an error dialog if there's any uncaught exception or promise rejection.
// This gets set up on all pages that include util.ts.
globalThis.addEventListener('unhandledrejection', (ev) => {
fail(`unhandled promise rejection, please report a bug!
https://github.com/webgpu/webgpu-samples/issues/new\n${ev.reason}`);
});
globalThis.addEventListener('error', (ev) => {
fail(`uncaught exception, please report a bug!
https://github.com/webgpu/webgpu-samples/issues/new\n${ev.error}`);
});

/** Shows an error dialog if getting an adapter wasn't successful. */
export function quitIfAdapterNotAvailable(
adapter: GPUAdapter | null
Expand Down