Support nullOrAllUuid and nullOrAllIsInstanceOf #312
Closed
+62
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadowhand
reviewed
Mar 19, 2025
| { | ||
| static::isIterableOrNull($value); | ||
|
|
||
| foreach ($value ?? [] as $entry) { |
Collaborator
There was a problem hiding this comment.
This isn't allowed here, we need to have PHP 7.4 compatibility I believe.
shadowhand
requested changes
Nov 24, 2025
Collaborator
shadowhand
left a comment
shadowhand
left a comment
There was a problem hiding this comment.
This needs a rebase for PHP 8.4.
| } | ||
| } | ||
|
|
||
| public static function isIterableOrNull($value, $message = '') |
Collaborator
There was a problem hiding this comment.
I believe this this already covered by isNullOrIterable in mixin?
| } | ||
| } | ||
|
|
||
| public static function nullOrAllIsInstanceOf($value, $class, $message = '') |
Collaborator
There was a problem hiding this comment.
This class should only be modified by running php bin/generate.php. So the underlying modification allUuid would need to be added to Assert, and then regenerating Mixin will add these methods automatically.
Collaborator
|
I've looked through this more closely, and we already have:
While it isn't quite the same, it effectively covers these cases already. Going to mark this as wontfix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.