Skip to content

Conversation

@jmfeurprier
Copy link
Contributor

@jmfeurprier jmfeurprier commented Jan 11, 2026

This should make all $value parameters back to mixed (like in v1) for methods all* and allNullOr*, and iterable return types coherent for methods allNullOr*.

@jmfeurprier jmfeurprier marked this pull request as ready for review January 11, 2026 22:26
@shadowhand
Copy link
Collaborator

This looks good, but I need to think about it a bit. Technically, this would be a BC break in signature, which would require a version 3.0. But if we're going to do a new major, then I would rather be removing the inner static::isIterable($value) check instead.

@jmfeurprier
Copy link
Contributor Author

Please see #337 (comment)

@shadowhand shadowhand merged commit b789271 into webmozarts:master Jan 13, 2026
9 checks passed
@shadowhand
Copy link
Collaborator

Released in version 2.1.2.

@shadowhand shadowhand self-requested a review January 13, 2026 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants