This repository was archived by the owner on Jul 13, 2021. It is now read-only.
[WIP] feat: add support for a split server / client configuration
#83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add options `{server: {host, port}, client: {host, port, secure}}`
* secondary effect options.server can be a server instance or a definition object
* all options are set in importance order, compatiblity is preserved (at least it should be)
* for clarity introduce websocketServer & websocketClient computed options
Contributor
|
Thanks for the PR 🍺 While that's not exactly the implementation we're going for (and the changes in the client scripts would be considered breaking), I'm only going to put a We haven't quite arrived at how we're going to work with the actual server yet though. So again I don't want to close this, but we can't accept it right this moment and you might have to do some rebasing soon. |
Author
|
Oopsy I was in a rush and did not see #80 No problem, I was testing things because we just need this feature right now, so why not sharing you know... |
Contributor
|
Absolutely! Glad you did! |
6 tasks
michael-ciniawsky
changed the title
server / client configuration
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{server: {host, port}, client: {host, port, secure}}This PR contains a:
Motivation / Use-Case
see #79
Breaking Changes
Trying my best not to.
Additional Info