-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
feat: publicPath output #5434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
adubrouski
wants to merge
6
commits into
webpack:master
Choose a base branch
from
adubrouski:publicPath-output
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+97
−5
Open
feat: publicPath output #5434
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ba4acf1
feat: publicPath output
adubrouski 89eb799
feat: add info message when public path equals 'auto' or function
adubrouski 2323bf3
Merge branch 'master' into publicPath-output
adubrouski 2e68d84
feat: show info message only if publicPath is function
adubrouski a1d7f0c
Merge branch 'master' into publicPath-output
adubrouski 96bff25
Merge branch 'master' into publicPath-output
adubrouski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
"use strict"; | ||
|
||
console.log("i am foo!"); |
11 changes: 11 additions & 0 deletions
11
test/fixtures/cli-output-public-path-config/webpack.config.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
"use strict"; | ||
|
||
const { join } = require("path"); | ||
|
||
module.exports = { | ||
mode: "development", | ||
entry: join(__dirname, "foo.js"), | ||
output: { | ||
publicPath: "/foo/", | ||
}, | ||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need respect
function
too... But yeah, we known about it only after compilation, so maybe we can improve our message and write - something likeyou can have custom public path, please navigate in your browsers to the point that you required
(just an example, feel free to improve it)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexander-akait I think adding an info message if public path is
auto
orfunction
would be a good idea, can you check this commit?