docs: fix webpack.config.js example for ESM and CommonJS #7735
+8
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Kritank07 is attempting to deploy a commit to the OpenJS Foundation Team on Vercel. A member of the Team first needs to authorize it. |
evenstensberg
requested changes
Jan 6, 2026
|
|
||
| ```javascript | ||
| import path from 'path'; | ||
| ```js |
|
|
||
| export default { | ||
| entry: './src/index.js', | ||
| module.exports = { |
Member
There was a problem hiding this comment.
instead of removing the logic here, move the __dirname logic below the import. Dont delete the es module expamples, we are transitioning from cjs -> esm
Author
There was a problem hiding this comment.
Thanks for the feedback — got it 👍
I’ll keep the original javascript code fence pragma and move the __dirname logic below the import instead of removing the ESM example.
I’ll update the PR accordingly.
|
|
||
| export default { | ||
| entry: './src/index.js', | ||
| entry: "./src/index.js", |
Member
There was a problem hiding this comment.
Nearly there! Dont change the string literals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title:
docs: fix webpack.config.js example for __dirname issue
Description:
The current Getting Started guide example uses __dirname in an ES module context, which can cause errors in modern Node.js environments because __dirname is not defined in ESM.
This PR:
"Clarifies the correct CommonJS usage"
"Adds a short note and example for using __dirname in ES modules"