Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pm2-runtime to IGNORED_GLOBAL_BINARIES constant #915

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

meowsus
Copy link

@meowsus meowsus commented Jan 17, 2025

I'm proposing we add pm2-runtime to the list of IGNORED_GLOBAL_BINARIES based on this documentation which indicates that pm2 should be installed globally inside of Docker containers and invoked using the pm2-runtime binary.

In my specific use case we have a script in our package.json file called workers:prod which uses this binary, e.g. pm2-runtime start pm2.config.js, which will fail the knip --include binaries check since its not added to our package and is only necessary in our production environment.

I'm curious if others have a strong feeling for or against including this entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant