Move requiresCrawls and requiredByCrawls to BaseCrawl #3105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikreymer
approved these changes
Jan 12, 2026
Member
ikreymer
left a comment
ikreymer
left a comment
There was a problem hiding this comment.
I guess we don't have a separate UploadedCrawlOut so should work for serialization as well.
Member
Author
Yes, CrawlOut doesn't inherit from anything and already has these defined, so should be good on that front. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3103
Small tweak to move
requiresCrawlsandrequiredByCrawlsfrom theCrawlmodel toBaseCrawl, as uploaded crawls that are part of a collection being used as a deduplication source may also have these (specificallyrequiredByCrawls) defined.