Upgrade greenlet and gevent for Python 3.12 support#958
Merged
Conversation
This was referenced Sep 30, 2025
Closed
|
@tw4l & @ikreymer would it be possible to get a new official release (including official Docker image) with this patch please? There is a critical 9.8 CVE in gevent (22.10.2) which this PR resolves with the python version bump. Thank you very much. |
Member
|
Hi @axllent, just in case you didn't see, this is now released in pywb 2.9.1: https://github.com/webrecorder/pywb/releases/tag/v-2.9.1 |
|
Thank you @tw4l, I appreciate the heads-up 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adjusts the requirements.txt file for versions of greenlet and gevent that look like they work with Python 3.12 by specifying different versions based on which Python version is installing them. Selected versions are based on the Changes lists for those packages and takes into account the httbin dependencies (httpbin now supports Python 3.12).
Motivation and Context
This is to make it minimally viable to run pywb with Python 3.12. It would fix #954.
I ran tests locally, but no matter with this requirements change or not, on various versions of python, 3 tests related to live video stuff (youtube) fail. I see these tests are marked to be skipped though when run via CI.
Screenshots (if appropriate):
Types of changes
Checklist: