Better fix for #865 / differentiate between remote cdx + local WARCs and remote cdx + liveweb loader#959
Merged
Conversation
Differentiate between when LiveWebLoader is used for fully remote loading (eg. remote CDX + pywb) vs just remote index (remote CDX + local WARCs) by checking if 'archive_paths' has been explicitly set. If it has, then skip LiveWebLoader when filename/offset are provided (to fallback to revisit)
This was referenced Oct 3, 2025
0x1b5b
pushed a commit
to 0x1b5b/pywb
that referenced
this pull request
Oct 22, 2025
Differentiate between when LiveWebLoader is used for fully remote loading (eg. remote CDX + pywb) vs just remote index (remote CDX + local WARCs) by checking if 'archive_paths' has been explicitly set. If it has, then skip LiveWebLoader when filename/offset are provided (to fallback to revisit)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix is to be more concretely differentiate between these two configurations:
The former is for proxying via remote CDX while the latter is the recommend config for OutbackCDX
These supersedes the fix proposed in #917 by adding a conditional to check which configuration is used
(remote cdx + local loading or remote cdx + remote liveweb loading) by checking if
archive_pathswas provided,as is needed for usage with OutbackCDX
The skipping of the livewebloader
is needed to be able to retry the lookup path again for revisit records, while of course remote proxying
will not need to do that.
Fixes #865
Screenshots (if appropriate):
Types of changes
Checklist: