Mock IA CDX response in test_agg_select_mem_unrewrite_headers#987
Merged
Conversation
The IA CDX service frequently times out causing transient failures of this test.
|
This is a good idea. cdx_toolkit testing is now 100% mocked because of IA's cdx api and Common Crawl's cdxj api have a lot of rate limits, thanks to abuse. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This makes test_agg_select_mem_unrewrite_headers use a local fixture instead of the live response from
https://web.archive.org/cdx.Motivation and Context
The IA CDX service frequently times out causing transient test failures.
Types of changes
Checklist: