Skip to content

Hotfix/issue#315 security bulk operations#319

Open
we-shivang-g001-v1 wants to merge 21 commits into
2.xfrom
hotfix/issue#315-security-bulk-operations
Open

Hotfix/issue#315 security bulk operations#319
we-shivang-g001-v1 wants to merge 21 commits into
2.xfrom
hotfix/issue#315-security-bulk-operations

Conversation

@we-shivang-g001-v1
Copy link
Copy Markdown

Fix: Add missing permission checks to bulk operations across controllers

Description

This PR fixes critical authorization gaps where bulk operations were skipping permission checks, allowing unauthorized users to perform destructive actions.


Changes Implemented

  • Added permission checks to bulk endpoints to match single-item operations
  • Ensured consistent use of hasPermission() / hasPermissions() across controllers

Fixed Issues

  1. UsersController::deleteList()

    • Added can-delete-users permission check
  2. FailedJobsController

    • updateList() → Added can-update-failed-jobs
    • listAction() → Added action-based permission checks
  3. BatchesController

    • deleteList() → Added delete permission check
    • listAction() → Added action-based permission validation

Root Cause

Bulk operations did not enforce authorization checks, while single-item operations already had proper permission validation. This PR aligns both behaviors.


Impact

  • Prevents unauthorized bulk delete/update/actions
  • Ensures consistent and secure permission handling across the application

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant