Hotfix/issue#315 security bulk operations#319
Open
we-shivang-g001-v1 wants to merge 21 commits into
Open
Conversation
…perations' into hotfix/issue#315-security-bulk-operations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Add missing permission checks to bulk operations across controllers
Description
This PR fixes critical authorization gaps where bulk operations were skipping permission checks, allowing unauthorized users to perform destructive actions.
Changes Implemented
hasPermission()/hasPermissions()across controllersFixed Issues
UsersController::deleteList()
can-delete-userspermission checkFailedJobsController
updateList()→ Addedcan-update-failed-jobslistAction()→ Added action-based permission checksBatchesController
deleteList()→ Added delete permission checklistAction()→ Added action-based permission validationRoot Cause
Bulk operations did not enforce authorization checks, while single-item operations already had proper permission validation. This PR aligns both behaviors.
Impact