Expose configuration for ice connection attempts#90
Merged
Conversation
Member
|
LGTM. But please fix fmt warnings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #90 +/- ##
=======================================
Coverage 71.23% 71.24%
=======================================
Files 442 442
Lines 67356 67361 +5
=======================================
+ Hits 47979 47989 +10
+ Misses 19377 19372 -5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Ok, I made the changes suggested by the formatter. |
rainliu
approved these changes
May 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If my analysis is right, the default ICE configuration allows ICE to attempt to connect a candidate for up to 1.4 seconds before marking the candidate as failed. In my app, I'd like to allocate more time to connection attempts. This PR exposes the configuration options that allow re-configuring that behavior, to allow longer connection attempt times.
I think the
ice_intervalsetting was intended to be an internal implementation detail? But considering the effect of this setting on ICE connection attempts, this PR promotes it to public configuration. Maybe that's not something you want? Or maybe my analysis is wrong? Let me know what you think of these changes.Thanks,
Jeff