Refactor: Rename peer connection variables#1722
Merged
fippo merged 2 commits intowebrtc:gh-pagesfrom Nov 17, 2025
Merged
Conversation
Rename 'localPeerConnection' to 'pc1' and 'remotePeerConnection' to 'pc2' across the codebase. Additionally, rename 'localConnection' to 'pc1' and 'remoteConnection' to 'pc2', and remove explicit 'window.localConnection' and 'window.remoteConnection' assignments. This refactoring improves consistency and brevity in variable naming for peer connection objects.
fippo
force-pushed
the
peerconnection-naming
branch
from
41a8ecb to
ccd55f4
Compare
Collaborator
Author
|
(gotta spend todays free gemini tokens and this has annoyed me for years!) |
alvestrand
approved these changes
Nov 17, 2025
Contributor
alvestrand
left a comment
alvestrand
left a comment
There was a problem hiding this comment.
Now if we had tests covering all of these, we might even feel confident that it still worked...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename 'localPeerConnection' to 'pc1' and 'remotePeerConnection' to 'pc2' across the codebase. Additionally, rename 'localConnection' to 'pc1' and 'remoteConnection' to 'pc2', and remove explicit 'window.localConnection' and 'window.remoteConnection' assignments.
Prompt for gemini:
(and then repeated for "localConnection")