Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom privacy settings #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jehartzog
Copy link

I used this lib, but had to follow up every upload with a second call to set my videos privacy to 'disable'. We are using Vimeo to embed videos, so that was the setting we needed.

Eventually I enabled 'Private Mode' on Vimeo, which actually caused uploads to fail because this library first tried to set two options which were not supported in that mode. That drove me to finally update this and make it work for more uses cases, as requested in #14.

I tested this with my app and it worked fine, I didn't test the updates to index.html but they are pretty simple.

@jehartzog jehartzog mentioned this pull request Aug 16, 2017
@kevinpaulconnor
Copy link

Any reason why this hasn't been merged? I was about to make my own very similar PR and it seems like a pretty trivial change.

@dauris
Copy link

dauris commented Jan 8, 2019

I am using your method but when I attempt to upload and use the unlisted value but it always uploads as 'anybody'
I've added privacy: 'unlisted',
within vimeo-uploads.js file I added 'privacy.view': (opts.privacy > '') ? opts.privacy : defaults.privacy
any suggestion

Hydraner added a commit to Hydraner/vimeo-upload that referenced this pull request Jun 1, 2021
@jrfii-animation
Copy link

Hello, everyone!

I know that I'm quite late to this discussion, but I was wondering if anyone that has had trouble getting this to work properly has any helpful advice for me. Like @dauris, it seems that no matter what I do, the video's 'privacy.view' is set to 'anybody.' Between @jehartzog suggested fix and Vimeo's documentation, found here:

https://developer.vimeo.com/api/reference/videos#edit_video

I feel that my attempts to get this working should have done the trick; however, I've had no such luck.

I'm trying to submit the upload as "Hidden from Vimeo," or, in other words, with 'privacy.view' set to 'disable.' I've tried countless variations that are centered around the various discussions here, and even have this value set on Vimeo's default upload settings.

Further, I'm currently using Vimeo's 30-day free trial for their Standard package.

Any thoughts and suggestions would be greatly appreciated. Thanks for your time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants