Open
Conversation
Author
|
Problem with travis failing is that older versions of node don't have |
Member
|
@lmatteis We already depend on https://www.npmjs.com/package/buffer-equals -- you can just use that. |
Author
|
@feross ah sweet. works! |
johnhenry
approved these changes
Apr 8, 2018
Member
|
@mafintosh Do you have any thoughts on this PR? It's been a while and I think we should merge or close at this point. I'm not familiar with the spec in question, so I'll defer to you |
Contributor
|
Yea, I need to take a closer look. I'll try to make some time over the next week to do so |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An important change is inside the
_closest()method, where I also store thevproperty found in replies. This could potentially increase memory footprint of a node. But I need to store the values somewhere to be able to compare them for the backoff algorithm.For info on the algorithm check the newly added Expiration section here: http://bittorrent.org/beps/bep_0044.html
Discussion #135