refactor: migrate storybook from v5 to v8 and update component stories #51
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,4 +13,5 @@ reports/ | |
| .DS_Store | ||
| npm-debug.log | ||
| .idea | ||
| .tsconfig-lint.json | ||
| *storybook.log | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import type { StorybookConfig } from '@storybook/react-webpack5'; | ||
|
|
||
| const config: StorybookConfig = { | ||
| addons: [ | ||
| '@storybook/addon-webpack5-compiler-swc', | ||
| '@storybook/addon-onboarding', | ||
| '@storybook/addon-links', | ||
| '@storybook/addon-essentials', | ||
| '@chromatic-com/storybook', | ||
| '@storybook/addon-interactions', | ||
| '@storybook/addon-a11y', | ||
| 'storybook-addon-intl' | ||
| ], | ||
| framework: { | ||
| name: '@storybook/react-webpack5', | ||
| options: {} | ||
| }, | ||
| stories: ['../app/components/**/stories/**/*.mdx', '../app/components/**/stories/**/*.stories.@(js|jsx|mjs|ts|tsx)'] | ||
| }; | ||
| export default config; | ||
|
Collaborator
There was a problem hiding this comment. I think we need to also add support for lingui. Because we move from react intl to lingui
Collaborator
There was a problem hiding this comment. https://github.com/wednesday-solutions/react-template/tree/master/.storybook Refer the files from here
Author
There was a problem hiding this comment. Right, Thank you for pointing that out! I've now added support for lingui |
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| import { translationMessages, appLocales, DEFAULT_LOCALE } from '../app/i18n'; | ||
|
|
||
| import type { Preview } from '@storybook/react'; | ||
|
|
||
| type TranslationMessages = { | ||
| [key: string]: { [key: string]: string }; | ||
| }; | ||
|
|
||
| const getMessages = (locale: string) => (translationMessages as TranslationMessages)[locale]; | ||
|
|
||
| const preview: Preview = { | ||
| parameters: { | ||
| controls: { | ||
| matchers: { | ||
| color: /(background|color)$/i, | ||
| date: /Date$/i | ||
| } | ||
| }, | ||
| intl: { | ||
| locales: appLocales, | ||
| defaultLocale: DEFAULT_LOCALE, | ||
| getMessages | ||
| } | ||
| } | ||
| }; | ||
|
|
||
| export default preview; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import React from 'react'; | ||
| import { Meta, Story } from '@storybook/react'; | ||
| import { Clickable } from '../index'; | ||
|
|
||
| export default { | ||
| title: 'Clickable', | ||
| component: Clickable | ||
| }; | ||
|
|
||
| const ClickableTemplate = (args) => <Clickable {...args} />; | ||
|
|
||
| export const ClickableStoryComponent = ClickableTemplate.bind({}); | ||
| ClickableStoryComponent.args = {}; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,19 @@ | ||
| import React from 'react'; | ||
| import { MemoryRouter } from 'react-router-dom'; | ||
| import Header from '../index'; | ||
|
|
||
| export default { | ||
| title: 'Header', | ||
| component: Header | ||
| }; | ||
|
|
||
| const HeaderTemplate = (args) => ( | ||
| <MemoryRouter> | ||
| <Header {...args} /> | ||
| </MemoryRouter> | ||
| ); | ||
|
|
||
| export const HeaderStoryComponent = HeaderTemplate.bind({}); | ||
| HeaderStoryComponent.args = { | ||
| id: 'Header' | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,28 +1,27 @@ | ||
| import React from 'react'; | ||
| import LaunchList from '../index'; | ||
|
|
||
| export default { | ||
| title: 'LaunchList', | ||
| component: LaunchList | ||
| }; | ||
|
|
||
| const LaunchListTemplate = (args) => <LaunchList {...args} />; | ||
|
|
||
| export const LaunchListStoryComponent = LaunchListTemplate.bind({}); | ||
| LaunchListStoryComponent.args = { | ||
| launchData: { | ||
| launches: [ | ||
| { | ||
| id: '1', | ||
| launchDateUtc: '2014-01-06T14:06:00', | ||
| missionName: 'Thaicom 6', | ||
| links: { | ||
| wikipedia: 'https://en.wikipedia.org/wiki/Thaicom_6', | ||
| flickrImages: ['https://farm9.staticflickr.com/8617/16789019815_f99a165dc5_o.jpg'] | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| loading: false | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also can we add the configuration to auto generate docs
docs: {
autodocs: true
},
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, done !