-
-
Notifications
You must be signed in to change notification settings - Fork 1
👷 Track Rust performance benchmarks on CI #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [criterion](https://github.com/bheisler/criterion.rs) from 0.5.1 to 0.7.0. - [Changelog](https://github.com/bheisler/criterion.rs/blob/master/CHANGELOG.md) - [Commits](bheisler/criterion.rs@0.5.1...0.7.0) No need to use the criterion.rs fork set at f07ae72/#27, because the original error `assertion failed: slice.len() > 1 && slice.iter().all(|x| !x.is_nan())` can been fixed by setting nresamples to 2, yeah I know right!
151a34a to
a764ece
Compare
Use codspeed-criterion-compat crate inplace of criterion, and setup CI job to run the Rust benchmarks!
d404eef to
1a4dc71
Compare
And bump to georust/gdal version with GDAL 3.11 bindings.
1a4dc71 to
e30a4ea
Compare
Fix `failed to update submodule `gdal-src/source` ... Caused by: path too long: 'C:/Users/runneradmin/.cargo/git/checkouts/gdal-3b51095beae5b4fc/3df2c28/gdal-src/source/...`.
Fix `undefined reference to `GDALGetRasterBand'` and various other linker errors. Just rely on existing GDAL installation within the docker container, rather than the pre-built bindings.
bf1240b to
2ec5fe3
Compare
Benchmark reading with GDAL 3.11's LiberTIFF driver, using 4 threads. Also renumbered the benchmark IDs to start from 0.
Owner
Author
|
Only thing that's not ported over from weiji14/foss4g2025#3 is the LZW compression stuff. Will probably do that in the future, when thinking about more Rust benchmarks (e.g. across a suite of compression types and predictor settings). |
Ensure fair comparison between nvTIFF which reads to CUDA memory (even though it's the fastest already), and the GDAL LiberTIFF and image-tiff backend readers.
15e8fb6 to
07d4b4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monitoring the performance of Rust benchmarks (in addition to the current Python ones). Also porting over some of the benchmark improvements from weiji14/foss4g2025#3.
TODO:
References: