Skip to content

Update#8

Open
mukkoo wants to merge 41 commits into
welaika:masterfrom
mukkoo:master
Open

Update#8
mukkoo wants to merge 41 commits into
welaika:masterfrom
mukkoo:master

Conversation

@mukkoo

@mukkoo mukkoo commented Oct 8, 2018

Copy link
Copy Markdown

Update sublime files with more linters and new settings

@mukkoo mukkoo self-assigned this Oct 8, 2018
@mukkoo
mukkoo requested review from namuit and ramensoup October 8, 2018 18:16

@alessandro-fazzi alessandro-fazzi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey I'm really happy to sse this one from a still-sturdy Sublime's user!

Generally I need to understand better some configurations, but there are a couple of more generally useful comments, such as the Wordpress package exclusion and the node binary config.

Thanks for the update/contrib ;) <3

Comment thread .gitignore
*.last-run
Package Control.ca-list
*ca-bundle
sublime/User/oscrypto-ca-bundle.crt

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind to explain the nature of this certificate file? I can't get it by myself :)

"Materialize",
"Javascript Beautify",
"JavaScriptNext - ES6 Syntax",
"Laravel Blade Highlighter",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be affordable to exclude this from the PR? Or it will be easier to iterate with a new commit?

Asking about it 'cos we don't use laravel nor blade in weLaika ;)

Comment on lines +46 to +47
"Svelte",
"Svelte Snippets",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be affordable to exclude this from the PR? Or it will be easier to iterate with a new commit?

Asking about it 'cos we don't - yet? - use svelte in weLaika ;)

],
"bold_folder_labels": true,
"color_scheme": "Packages/User/SublimeLinter/Material Spacegray (SL).tmTheme",
"color_scheme": "Packages/Edge Theme/Edge Night Sky.tmTheme",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AHAH! Isn't this one too much opinionated? 😂 I'm ready to accept it since i cannot verify myself how much cool it is 😉

"Vintage"
"Markdown",
"Vintage",
"WordPress"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this needs to be ignored? I doubt it is a default package... 🤔

"paths": {
"linux": [],
"osx": [
"~/.rbenv/shims"

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️


"eslint": {
"disable_if_not_dependency": true,
"env": { "PATH": "/usr/local/opt/node@8/bin" }

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one sounds awkward. Node8 is really old and I'd expect nvm to be used into projects. I'm i missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants