-
Notifications
You must be signed in to change notification settings - Fork 288
WELD-2810 Add support for sealed classes to the implementation of CDI Lang Model (+ bump to CDI 5.0) #3122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The first commit depends on weld/api#225 and again, doesn't necessarily have to be correct. The second commit should be good. |
I've sent #3132 to upgrade project version (and similar for API). |
tests-arquillian/src/test/java/org/jboss/weld/tests/extensions/SimpleExtension.java
Show resolved
Hide resolved
90095e7
to
7701c21
Compare
I have updated this branch and rebased it onto Though running it locally, I can now see all the tests passing 👍 |
You really should feel free to bump to CDI 5.0 API / Weld 7.0 API elsewhere, if that suits you better. The core value of this PR has always been the implementation of the sealed classes support in the lang model. |
7701c21
to
2ae5805
Compare
Updated Weld API and CDI TCK versions to newly released Alpha1 versions; moved from draft to ready for review. |
1b378a9
to
dcc04d0
Compare
Uff, these failures are related but I am not sure how much we can do now. There are calls to I'll poke around WFLY internals to at least get clarity on what the problems are and create some tracking issue for them... |
Few notes to myself after poking around this today:
To begin with, we should use the preview WFLY artifact but that does expose other problems such as adding a JMS queue that some tests are using. Apparently, the preview WFLY has different configuration files and the relevant subsystem is no longer pre-configured. |
Update Weld API to 7.0.Alpha1.
dcc04d0
to
3c2fd63
Compare
3c2fd63
to
74eaf5b
Compare
…least CDI artifacts.
16c9267
to
d85f3ad
Compare
… based for EE11 (due to BM#getELResolver calls)
Ok, this is about as far as I can get with testing it this early (short of building custom WFLY dist) - With that in mind, I have added a commit that should disable all WFLY incontainer CI tests for now - they will still show in the CI run overview (as skipped) but won't get in the way. |
JIRA - https://issues.redhat.com/browse/WELD-2810