[WIP] Add macos toolchain #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheLortex
requested changes
Mar 23, 2020
Member
TheLortex
left a comment
TheLortex
left a comment
There was a problem hiding this comment.
Hi, thank you for your contribution !
I won't be able to test it on macos but if it works for you I'm happy to merge it as soon as the requested changes are made.
| depends: [ | ||
| "gcc-toolchain-esp32" | ||
| "gcc-toolchain-esp32" { os = "linux" } | ||
| "macos-toolchain-esp32" { os != "linux" } |
Member
There was a problem hiding this comment.
Is it possible to have something more precise than { os != "linux" } for macos ? I wouldn't want windows people to download this inadvertently !
Looks like os = "macos" should do the trick.
| "ocamlfind" | ||
| ] | ||
| "gcc-toolchain-esp32" { os = "linux" } | ||
| "macos-toolchain-esp32" { os != "linux" } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and update some packages to opam 2.0