Use dupIO to avoid unwanted sharing when encoding #321
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces an optional dependency on
dupIO
for use when encoding, to avoid unwanted sharing as described at #318. (See #319 for an alternative approach adding a new token constructor.) I've also incorporated a fix to #317, though this doesn't seem to make a massive difference to encoding performance.It calls
dupIO
before evaluating each token in the stream. Originally I tried callingdupIO
only once the buffer was full, but testing the approach on the client's codebase indicated that this was not enough to avoid the issue.Since it is unclear how much performance cost
dupIO
incurs in general, and it may be undesirable as a dependency, it is gated behind an off-by-default flag. (This raises the question of how to test it in CI...)