Drop runFold#4
Merged
Merged
Conversation
The contract of `runFold` promised ```hs --- If the fold has an associated exception handler, it will get a chance to --- catch any exceptions thrown. See 'foldWithHandler' for detailed discussion. ``` but that is a contract it could not keep: after all, the whole point for introducing `foldWithHandler` in the first place was that we need to treat these handlers very carefully, simply using `handle` does not work. It turns out we don't actually _need_ `runFold`, so deleted it altogether; I think this clarifies the situation on the `hs-bindgen` side also (see discussion of `topLevelFold` there).
edsko
enabled auto-merge
September 19, 2025 05:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The contract of
runFoldpromisedbut that is a contract it could not keep: after all, the whole point for introducing
foldWithHandlerin the first place was that we need to treat these handlers very carefully, simply usinghandledoes not work.It turns out we don't actually need
runFold, so deleted it altogether; I think this clarifies the situation on thehs-bindgenside also (see discussion oftopLevelFoldthere).