Generate foreign imports related to tokens automatically using clang-bootstrap#44
Merged
Merged
Conversation
jorisdral
commented
Mar 11, 2026
jorisdral
marked this pull request as ready for review
March 11, 2026 14:38
jorisdral
commented
Mar 11, 2026
edsko
approved these changes
Mar 18, 2026
edsko
left a comment
edsko
left a comment
Collaborator
There was a problem hiding this comment.
Feel free to merge once the changes we discussed are done.
This makes it clearer that `R` and `W` are boxed, unlifted types.
jorisdral
force-pushed
the
jdral/clarify-cxtoken-representation
branch
from
March 20, 2026 11:11
4598fea to
6353423
Compare
jorisdral
enabled auto-merge
March 20, 2026 11:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #41
I first had to change the code a bit to explain better why handling of the
CXTokenstruct has to be different from the handling of other structs. The short story is:CXTokens are allocated bylibclangand maintained by C. Memory for other structs are typically allocated on the Haskell side. But once that was in place, automatically generating the foreign imports was simple.