Remove LLVM_CONFIG configuration variable#62
Merged
Merged
Conversation
This commit removes the `LLVM_CONFIG` configuration variable. Users
should configure `PATH` so that the desired `llvm-config` is found.
The motivation for this change is that we also use the `clang`
executable. It is expected behavior to find `clang` via `PATH` or
`${LLVM_PATH}/bin`, while finding it via `LLVM_CONFIG` is potentially
unexpected.
The logic is simplified. `LLVM_PATH` is used if set. Otherwise,
`llvm-config` is used if found. There is a configuration error if
`LLVM_PATH` is not set and `llvm-config` is not found.
If users do not want to use `LLVM_PATH`, then it should not be set.
Note that the `KyleMayes/install-llvm-action` action sets this
environment variable. (We will likely stop using that action in the
future so that we can test new versions soon after they are released.)
Collaborator
|
@bolt12 Can you verify if |
This was referenced May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes the
LLVM_CONFIGconfiguration variable. Users should configurePATHso that the desiredllvm-configis found. The motivation for this change is that we also use theclangexecutable. It is expected behavior to findclangviaPATHor${LLVM_PATH}/bin, while finding it viaLLVM_CONFIGis potentially unexpected.The logic is simplified.
LLVM_PATHis used if set. Otherwise,llvm-configis used if found. There is a configuration error ifLLVM_PATHis not set andllvm-configis not found.If users do not want to use
LLVM_PATH, then it should not be set. Note that theKyleMayes/install-llvm-actionaction sets this environment variable. (We will likely stop using that action in the future so that we can test new versions soon after they are released.)